From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17029 invoked by alias); 30 Jun 2004 01:52:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16946 invoked from network); 30 Jun 2004 01:51:58 -0000 Received: from unknown (HELO lakermmtao04.cox.net) (68.230.240.35) by sourceware.org with SMTP; 30 Jun 2004 01:51:58 -0000 Received: from white ([68.9.64.121]) by lakermmtao04.cox.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20040630015154.PYON29176.lakermmtao04.cox.net@white> for ; Tue, 29 Jun 2004 21:51:54 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1BfUG9-0001G9-00 for ; Tue, 29 Jun 2004 21:51:37 -0400 Date: Wed, 30 Jun 2004 01:52:00 -0000 From: Bob Rossi To: gdb-patches@sources.redhat.com Subject: Re: gdb.mi/mi2-file.exp: ChangeLog, copyright, sync with mi-file.exp Message-ID: <20040630015136.GD4791@white> Mail-Followup-To: gdb-patches@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.28i X-SW-Source: 2004-06/txt/msg00686.txt.bz2 > >>I am going to update the mi-file.exp to test my new functionality. I > >>>am going to make mi2-file.exp the way it was before I changed it. > >>>So, I should have a changelog only for mi-file.exp. > >>> mi2-file.exp will be reverted to as it was before my change. > >>> mi-file.exp will test the new command -file-list-exec-source-files. > > > > > >Generally we don't retroactively edit ChangeLog's, we only add > >new entries. > > > >I would do: > > > >(1) Revert the change to mi2-file.exp. Use a normal ChangeLog > > entry for this, which says: "mi2-file.exp: Reverted undocumented > > change from 2004-NN-NN". Send it to gdb-patches and ask > > Andrew or Elena to approve it. > > Yes, that's approved. > > >(2) Write a new patch for mi-file.exp, with a normal ChangeLog > > entry, and remember to hit the copyright years. > > Again, that's approved. Here is the patch, ready to approve? It basically reverts mi2-file.exp to version 1.1, except changing the name of the test which was originally wrong ( thanks to cut/paste ). Also, update mi-file.exp to have the test for -file-list-exec-source-files. 2004-06-29 Bob Rossi * gdb.mi/mi2-file.exp: Revert to version 1.1, except changed name of test from test_tbreak_creation_and_listing to test_file_list_exec_source_file * gdb.mi/mi-file.exp: Add test for -file-list-exec-source-files Changed name of test from test_tbreak_creation_and_listing to test_file_list_exec_source_file Index: gdb.mi/mi-file.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-file.exp,v retrieving revision 1.1 diff -w -u -r1.1 mi-file.exp --- gdb.mi/mi-file.exp 2 Apr 2003 22:10:35 -0000 1.1 +++ gdb.mi/mi-file.exp 30 Jun 2004 01:42:45 -0000 @@ -1,4 +1,4 @@ -# Copyright 1999 Free Software Foundation, Inc. +# Copyright 1999, 2004 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -47,7 +47,7 @@ mi_gdb_reinitialize_dir $srcdir/$subdir mi_gdb_load ${binfile} -proc test_tbreak_creation_and_listing {} { +proc test_file_list_exec_source_file {} { global srcfile global srcdir global subdir @@ -59,7 +59,17 @@ "request path info of current source file (${srcfile})" } -test_tbreak_creation_and_listing +proc test_file_list_exec_source_files {} { + global srcfile + + # get the path and absolute path to the current executable + mi_gdb_test "222-file-list-exec-source-files" \ + "222\\\^done,files=\\\[\{file=\".*/${srcfile}\",fullname=\"/.*/${srcfile}\"\},\{file=\".*\"\},\{file=\".*\"\},\{file=\".*\"\},\{file=\".*\"\}\\\]" \ + "Getting a list of source files." +} + +test_file_list_exec_source_file +test_file_list_exec_source_files mi_gdb_exit return 0 Index: gdb.mi/mi2-file.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-file.exp,v retrieving revision 1.2 diff -w -u -r1.2 mi2-file.exp --- gdb.mi/mi2-file.exp 10 Jun 2004 20:05:45 -0000 1.2 +++ gdb.mi/mi2-file.exp 30 Jun 2004 01:42:45 -0000 @@ -1,4 +1,4 @@ -# Copyright 1999 Free Software Foundation, Inc. +# Copyright 1999, 2004 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -59,17 +59,7 @@ "request path info of current source file (${srcfile})" } -proc test_file_list_exec_source_files {} { - global srcfile - - # get the path and absolute path to the current executable - mi_gdb_test "222-file-list-exec-source-files" \ - "222\\\^done,files=\\\[\{file=\".*/${srcfile}\",fullname=\"/.*/${srcfile}\"\},\{file=\".*\"\},\{file=\".*\"\},\{file=\".*\"\},\{file=\".*\"\}\\\]" \ - "Getting a list of source files." -} - test_file_list_exec_source_file -test_file_list_exec_source_files mi_gdb_exit return 0