From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34176-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1906 invoked by alias); 29 Jun 2004 14:39:10 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1897 invoked from network); 29 Jun 2004 14:39:07 -0000
Received: from unknown (HELO cgf.cx) (66.30.22.40)
  by sourceware.org with SMTP; 29 Jun 2004 14:39:07 -0000
Received: by cgf.cx (Postfix, from userid 201)
	id 249C51B735; Tue, 29 Jun 2004 10:39:09 -0400 (EDT)
Date: Tue, 29 Jun 2004 14:39:00 -0000
From: Christopher Faylor <me@cgf.cx>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] testsuite/gdb.arch/i386-prologue.c: Fix compiling on cygwin
Message-ID: <20040629143909.GC17384@trixie.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sources.redhat.com
References: <20040628113516.GA19325@cygbert.vinschen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040628113516.GA19325@cygbert.vinschen.de>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2004-06/txt/msg00668.txt.bz2

On Mon, Jun 28, 2004 at 01:35:16PM +0200, Corinna Vinschen wrote:
>Hi,
>
>the gdb.arch/i386-prologue.c testcase doesn't compile on Cygwin since
>on Cygwin the assenmbler labels need leading underscores to match the
>same names in C.  The below patch fixes that.
>
>Corinna
>
>	* gdb.arch/i386-prologue.c: Conditionalize label names to build
>	on Cygwin.

SHouldn't there be a better conditional for this than "__CYGWIN__" like
"NAMES_HAVE_UNDERSCORE" or something?

cgf

>Index: gdb.arch/i386-prologue.c
>===================================================================
>RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-prologue.c,v
>retrieving revision 1.3
>diff -u -p -r1.3 i386-prologue.c
>--- gdb.arch/i386-prologue.c	29 Apr 2004 18:05:31 -0000	1.3
>+++ gdb.arch/i386-prologue.c	28 Jun 2004 11:32:02 -0000
>@@ -15,7 +15,11 @@ main (void)
> 
> asm(".text\n"
>     "    .align 8\n"
>+#ifdef __CYGWIN__
>+    "_gdb1253:\n"
>+#else
>     "gdb1253:\n"
>+#endif
>     "    pushl %ebp\n"
>     "    xorl  %ecx, %ecx\n"
>     "    movl  %esp, %ebp\n"
>@@ -28,7 +32,11 @@ asm(".text\n"
> 
> asm(".text\n"
>     "    .align 8\n"
>+#ifdef __CYGWIN__
>+    "_gdb1338:\n"
>+#else
>     "gdb1338:\n"
>+#endif
>     "    pushl %edi\n"
>     "    pushl %esi\n"
>     "    pushl %ebx\n"
>@@ -44,7 +52,11 @@ asm(".text\n"
> 
> asm(".text\n"
>     "    .align 8\n"
>+#ifdef __CYGWIN__
>+    "_jump_at_beginning:\n"
>+#else
>     "jump_at_beginning:\n"
>+#endif
>     "    pushl %ebp\n"
>     "    movl  %esp,%ebp\n"
>     "    jmp   .gdbjump\n"
>
>-- 
>Corinna Vinschen
>Cygwin Co-Project Leader
>Red Hat, Inc.