From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34161-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1048 invoked by alias); 28 Jun 2004 19:48:07 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1037 invoked from network); 28 Jun 2004 19:48:05 -0000
Received: from unknown (HELO lakermmtao12.cox.net) (68.230.240.27)
  by sourceware.org with SMTP; 28 Jun 2004 19:48:05 -0000
Received: from white ([68.9.64.121]) by lakermmtao12.cox.net
          (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP
          id <20040628194804.FZIU9233.lakermmtao12.cox.net@white>;
          Mon, 28 Jun 2004 15:48:04 -0400
Received: from bob by white with local (Exim 3.35 #1 (Debian))
	id 1Bf26k-0000oU-00; Mon, 28 Jun 2004 15:48:02 -0400
Date: Mon, 28 Jun 2004 19:48:00 -0000
From: Bob Rossi <bob@brasko.net>
To: Andreas Schwab <schwab@suse.de>
Cc: Elena Zannoni <ezannoni@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sources.redhat.com
Subject: Re: -file-list-exec-source-files
Message-ID: <20040628194802.GC2665@white>
Mail-Followup-To: Andreas Schwab <schwab@suse.de>,
	Elena Zannoni <ezannoni@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
	gdb-patches@sources.redhat.com
References: <20040306155700.GA9439@white> <20040311132508.GA2504@white> <20040329205545.GA26696@white> <20040405214043.GA2052@white> <20040412150620.GA9464@white> <20040420141001.GB4465@white> <uisft98sz.fsf@elta.co.il> <16519.59247.93650.941260@localhost.redhat.com> <20040426130529.GA11975@white> <je3c4gooyy.fsf@sykes.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <je3c4gooyy.fsf@sykes.suse.de>
User-Agent: Mutt/1.3.28i
X-SW-Source: 2004-06/txt/msg00653.txt.bz2

On Sun, Jun 27, 2004 at 08:06:13PM +0200, Andreas Schwab wrote:
> Bob Rossi <bob@brasko.net> writes:
> 
> > +/* Finds the fullname that a symtab represents.
> > +
> > +   If this functions finds the fullname, it will save it in ps->fullname
> > +   and it will also return the value.
> >  
> > +   If this function fails to find the file that this symtab represents,
> > +   NULL will be returned and ps->fullname will be set to NULL.  */
> 
> This causes gdb to crash in lookup_symtab.
> 
>     if (full_path != NULL)
>       {
> 	const char *fp = symtab_to_fullname (s);
> 	if (FILENAME_CMP (full_path, fp) == 0)
> 	  {
> 	    return s;
> 	  }
>       }
> 
>     if (real_path != NULL)
>       {
> 	char *rp = gdb_realpath (symtab_to_fullname (s));
>         make_cleanup (xfree, rp);
> 	if (FILENAME_CMP (real_path, rp) == 0)
> 	  {
> 	    return s;
> 	  }
>       }
> 
> Neither of these places expect symtab_to_fullname to return NULL.

I will have a simple patch for this within the next few hours.

Thanks,
Bob Rossi