Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] infcmd.c: Fix UI problem in attach_command
Date: Mon, 28 Jun 2004 17:09:00 -0000	[thread overview]
Message-ID: <20040628170947.GA12272@nevyn.them.org> (raw)
In-Reply-To: <7137-Mon28Jun2004195856+0300-eliz@gnu.org>

On Mon, Jun 28, 2004 at 07:58:57PM +0200, Eli Zaretskii wrote:
> > Date: Mon, 28 Jun 2004 13:14:18 +0200
> > From: Corinna Vinschen <vinschen@redhat.com>
> > > 
> > > Do you (or anyone else, like Elena) know why do we relinquish the
> > > terminal to the inferior while loading the symbol table?  It sounds
> > > like a strange thing to do at this point.
> > 
> > I don't know and it sounds strange to me as well.  I've tested a simlified
> > patch which just moves the call to target_terminal_inferior right before
> > the normal_stop call.  It works as good as my original patch, but I'm not
> > sure if there's a specific situation which requires an early switch to
> > the inferior.
> 
> I tend to suggest that we commit this simplified patch and see if
> anybody screams.

This seems reasonable to me; if the patch tested OK on one platform
with job control I don't think there are major terminal-handling
gotchas it might trigger.

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-06-28 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-26 12:11 Corinna Vinschen
2004-06-27 17:15 ` Eli Zaretskii
2004-06-28 11:14   ` Corinna Vinschen
2004-06-28 17:03     ` Eli Zaretskii
2004-06-28 17:09       ` Daniel Jacobowitz [this message]
2004-06-28 22:14         ` Jim Blandy
2004-06-29  6:39           ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040628170947.GA12272@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox