From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3193 invoked by alias); 27 Jun 2004 21:48:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3186 invoked from network); 27 Jun 2004 21:48:32 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Jun 2004 21:48:32 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BehVn-00080E-71; Sun, 27 Jun 2004 17:48:31 -0400 Date: Sun, 27 Jun 2004 21:48:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix frame ID comparison problem on s390 Message-ID: <20040627214831.GA30684@nevyn.them.org> Mail-Followup-To: Ulrich Weigand , Andrew Cagney , gdb-patches@sources.redhat.com References: <40D08438.8090009@gnu.org> <200406272047.WAA10464@faui1m.informatik.uni-erlangen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406272047.WAA10464@faui1m.informatik.uni-erlangen.de> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00617.txt.bz2 On Sun, Jun 27, 2004 at 10:47:58PM +0200, Ulrich Weigand wrote: > Andrew Cagney wrote: > > > with those changes its ok, > > Thanks; here's the version I finally committed. > > (Sorry it took so long, I got sidetracked by a kernel bug triggered > by running the gdb test suite that caused random kernel memory > corruption :-/) Thanks! Just one small nit. If you're going to do this: > + id.stack_addr_p = 1; > id.code_addr = code_addr; > + id.code_addr_p = 1; > id.special_addr = special_addr; > + id.special_addr_p = 1; Then these should be "unsigned int : 1": > + /* Flags to indicate the above fields have valid contents. */ > + int stack_addr_p : 1; > + int code_addr_p : 1; > + int special_addr_p : 1; > }; > > /* Methods for constructing and comparing Frame IDs. Some future version of GCC will warn about this mistake. The only valid values for "int : 1" are 0 and -1. -- Daniel Jacobowitz