From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25207 invoked by alias); 25 Jun 2004 13:55:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25167 invoked from network); 25 Jun 2004 13:55:03 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 25 Jun 2004 13:55:03 -0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5PDt2e1032671 for ; Fri, 25 Jun 2004 09:55:03 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5PDt2w28341 for ; Fri, 25 Jun 2004 09:55:02 -0400 Received: from cygbert.vinschen.de (vpn50-2.rdu.redhat.com [172.16.50.2]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i5PDt0P17438 for ; Fri, 25 Jun 2004 06:55:01 -0700 Received: by cygbert.vinschen.de (Postfix, from userid 500) id E1076582E2; Fri, 25 Jun 2004 15:54:57 +0200 (CEST) Date: Fri, 25 Jun 2004 13:55:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite/gdb.base/attach.exp: Fix some Cygwin problems Message-ID: <20040625135457.GT19325@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040625131649.GR19325@cygbert.vinschen.de> <20040625133447.GA21788@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040625133447.GA21788@nevyn.them.org> User-Agent: Mutt/1.4.2i X-SW-Source: 2004-06/txt/msg00533.txt.bz2 On Jun 25 09:34, Daniel Jacobowitz wrote: > On Fri, Jun 25, 2004 at 03:16:49PM +0200, Corinna Vinschen wrote: > > Hi, > > > > on Cygwin, some of the attach tests are simply failing because the > > corresponding output string isn't correctly checked for. The below > > patch fixes that partly. Some of the tests will need changes in GDB > > so I didn't care for them as part of this testsuite fix. > > > > Ok to check in? > > > > > > Corinna > > > > > > * gdb.base/attach.exp: Set testpid to Windows PID for Cygwin. > > (do_attach_tests): Add Cygwin specific strings to check for > > in the nonsense test, the boguspid test and the attach1 test. > > OK. Thanks for the quick review. Unfortunately I just found that this change is useless, unless some changes in win32-nat.c are made. I'll defer to apply this change until I have fixed the related problem in win32-nat.c Corinna -- Corinna Vinschen Cygwin Co-Project Leader Red Hat, Inc.