From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29238 invoked by alias); 24 Jun 2004 19:34:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29217 invoked from network); 24 Jun 2004 19:34:26 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 24 Jun 2004 19:34:26 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i5OJYPVL000957; Thu, 24 Jun 2004 21:34:25 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i5OJYORi017179; Thu, 24 Jun 2004 21:34:25 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i5OJYJS7017176; Thu, 24 Jun 2004 21:34:19 +0200 (CEST) Date: Thu, 24 Jun 2004 19:34:00 -0000 Message-Id: <200406241934.i5OJYJS7017176@elgar.kettenis.dyndns.org> From: Mark Kettenis To: m.mueller99@kay-mueller.de CC: gdb-patches@sources.redhat.com, binutils@sources.redhat.com In-reply-to: <40D6F901.3010008@kay-mueller.de> (message from Michael Mueller on Mon, 21 Jun 2004 17:04:33 +0200) Subject: Re: [RFC]: patch #2 for Sun C compiled target programs References: <40D32489.9070503@kay-mueller.de> <200406182159.i5ILxF9G001540@elgar.kettenis.dyndns.org> <40D6F901.3010008@kay-mueller.de> X-SW-Source: 2004-06/txt/msg00517.txt.bz2 Date: Mon, 21 Jun 2004 17:04:33 +0200 From: Michael Mueller > > *** Problem 2 ************************************************* > > Function sparc64_frame_base_address in sparc64-tdep.c needs to > be fixed: > > /* ??? Should we take BIAS into account here? */ > return cache->base; > > > The answer to the question in comment is yes, see the appended patch. > > That sounds reasonable. I'll commit that bit if it works with > GCC/DWARF too. I debugged gcc3.4/dwarf. It does not call sparc64_frame_base_address. (I assume dwarf uses a location expression of it's own to describe a fp based address + BIAS as the location of a stack variable.) Probably, yes. I've committed the attached. Thanks, Mark Index: ChangeLog from Mark Kettenis From Michael Mueller : * sparc64-tdep.c (sparc64_frame_base_address): Take BIAS into account. Index: sparc64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sparc64-tdep.c,v retrieving revision 1.12 diff -u -p -r1.12 sparc64-tdep.c --- sparc64-tdep.c 7 Jun 2004 02:02:55 -0000 1.12 +++ sparc64-tdep.c 24 Jun 2004 19:31:51 -0000 @@ -568,8 +568,7 @@ sparc64_frame_base_address (struct frame struct sparc_frame_cache *cache = sparc64_frame_cache (next_frame, this_cache); - /* ??? Should we take BIAS into account here? */ - return cache->base; + return cache->base + BIAS; } static const struct frame_base sparc64_frame_base =