From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23674 invoked by alias); 23 Jun 2004 23:01:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23645 invoked from network); 23 Jun 2004 23:01:40 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 23 Jun 2004 23:01:40 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BdGkN-0001ib-Gw; Wed, 23 Jun 2004 19:01:39 -0400 Date: Wed, 23 Jun 2004 23:01:00 -0000 From: Daniel Jacobowitz To: Jeff Johnston Cc: Andrew Haley , gdb-patches@sources.redhat.com Subject: Re: [RFA]: Java Inferior Call Take 2 Message-ID: <20040623230138.GA6426@nevyn.them.org> Mail-Followup-To: Jeff Johnston , Andrew Haley , gdb-patches@sources.redhat.com References: <40A9264C.4060404@redhat.com> <20040617030603.GC23443@nevyn.them.org> <40D20494.2020608@redhat.com> <20040619235857.GA18759@nevyn.them.org> <16598.64375.217285.743094@cuddles.cambridge.redhat.com> <16601.25623.949217.642524@cuddles.cambridge.redhat.com> <20040623134742.GA24612@nevyn.them.org> <40D9FC3B.3030700@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40D9FC3B.3030700@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00508.txt.bz2 On Wed, Jun 23, 2004 at 05:55:07PM -0400, Jeff Johnston wrote: > Daniel Jacobowitz wrote: > >On Wed, Jun 23, 2004 at 12:05:59PM +0100, Andrew Haley wrote: > > > >>This patch is now in mainline. Is there anything else you need? > > > > > >Yes. Two sets of questions left, one for Jeff and one [plus a little > >bit] for you... > > > > > >Jeff, one test still fails: calling addprint. I think this is mostly a > >GDB problem rather than GCC. Before starting the program I see this: > > > > Let me take a look at it. It is not failing in my all-patches-applied > build. Perhaps in splitting the patches up, I screwed up and missed > something. Thanks. > > - Should we suppress jvclass and the way we do for C++ > > artificial methods? > > > > Perhaps remove , but jvclass() is the constructor. There could be > multiple constructors and as an end-user, I would want to see the various > prototypes. I can't speak for what C++ does. In C++, the debug information marks whether a constructor was written by the user (i.e. the type really contains a constructor) or by the compiler (i.e. implicit). I imagine Java's debug information has the same thing. For minimum confusion, we choose not to print the artificial methods in C++ types; I think we should do the same for Java. (This shouldn't affect breakpointing it for users who know the constructor exists.) > > > - Why is it java::lang::Object instead of java.lang.Object? > > > > This is because we use the C++ class_name_from_physname() function which is > C++-specific. I had submitted another patch that was put out at the same > time which I don't think anybody has looked at which fixes this problem. > It has to do with adding class_name_from_physname to the language vector. OK, thanks. I reviewed it on the 16th. I failed to CC you on the message, though. Likewise the tab completion patch. > > - Why did printing of the type change? There's only one definition > > of jvclass in the debug info, and it's marked Java. > > > > There are checks in the code based on current language. The current > language does not start as java. If you manually change it via set > language java, you will see the same results before and after. Bleeeeeeech. Thanks for explaining; definitely not your problem, but definitely a bug. If we're printing a type we ought to be using the type's language. -- Daniel Jacobowitz