From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26682 invoked by alias); 17 Jun 2004 19:07:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26666 invoked from network); 17 Jun 2004 19:07:01 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 17 Jun 2004 19:07:01 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1Bb2E0-0007f6-HV; Thu, 17 Jun 2004 15:07:00 -0400 Date: Thu, 17 Jun 2004 19:07:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com, jimb@redhat.com Subject: Re: [rfc/testsuite] i386-sse.exp: better output if no SSE support Message-ID: <20040617190659.GA28934@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com, jimb@redhat.com References: <20040617185658.223484B104@berman.michael-chastain.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040617185658.223484B104@berman.michael-chastain.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00417.txt.bz2 On Thu, Jun 17, 2004 at 02:56:58PM -0400, Michael Chastain wrote: > This patch fixes i386-sse.exp for compilers that don't support SSE, > specifically gcc 2.95.3. Before this patch, the results are: > > 3 ERROR > 2 WARNING > 33 FAIL > 1 UNRESOLVED > > After this patch, the results are a single UNSUPPORTED. > My view is that people should be reading all their non-PASS results, > including the UNRESOLVED, UNSUPPORTED, and UNTESTED results. > We might want to discuss this. As far as I'm concerned this is absolutely a good change. I don't always carefully read the UNSUPPORTED / UNTESTED results, but I do at least look at them. And anything that makes gdb_suppress_entire_file go away is good in my book. > Fix PR testsuite/1679. > * gdb.arch/i386-sse.exp: Do not call gdb_suppress_entire file. > Issue an UNSUPPORTED result instead. "entire_file". -- Daniel Jacobowitz