Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: gdb-patches@sources.redhat.com, jimb@redhat.com
Subject: [rfc/testsuite] i386-sse.exp: better output if no SSE support
Date: Thu, 17 Jun 2004 18:57:00 -0000	[thread overview]
Message-ID: <20040617185658.223484B104@berman.michael-chastain.com> (raw)

This patch fixes i386-sse.exp for compilers that don't support SSE,
specifically gcc 2.95.3.  Before this patch, the results are:

   3 ERROR
   2 WARNING
  33 FAIL
   1 UNRESOLVED

After this patch, the results are a single UNSUPPORTED.
My view is that people should be reading all their non-PASS results,
including the UNRESOLVED, UNSUPPORTED, and UNTESTED results.
We might want to discuss this.

I tested this on native i686-pc-linux-gnu, gcc 2.95.3 and 3.3.3,
dwarf-2 and stabs+.  My processor has SSE (Intel Celeron).

I'm giving this 48 hours for comment and then committing it.

Michael C

2004-06-17  Michael Chastain  <mec.gnu@mindspring.com>

	Fix PR testsuite/1679.
	* gdb.arch/i386-sse.exp: Do not call gdb_suppress_entire file.
	Issue an UNSUPPORTED result instead.

Index: gdb.arch/i386-sse.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-sse.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 i386-sse.exp
*** gdb.arch/i386-sse.exp	7 Jun 2004 15:38:52 -0000	1.1
--- gdb.arch/i386-sse.exp	17 Jun 2004 18:44:46 -0000
*************** set testfile "i386-sse"
*** 35,41 ****
  set srcfile ${testfile}.c
  set binfile ${objdir}/${subdir}/${testfile}
  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
!     gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
  }
  
  gdb_exit
--- 35,42 ----
  set srcfile ${testfile}.c
  set binfile ${objdir}/${subdir}/${testfile}
  if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
!     unsupported "compiler does not support SSE"
!     return
  }
  
  gdb_exit


             reply	other threads:[~2004-06-17 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-17 18:57 Michael Elizabeth Chastain [this message]
2004-06-17 19:07 ` Daniel Jacobowitz
2004-06-17 20:40 ` Jim Blandy
2004-06-19 18:59 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040617185658.223484B104@berman.michael-chastain.com \
    --to=mec.gnu@mindspring.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox