Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Cc: Michael Coulter <coulter@cup.hp.com>,
	Jim Blandy <jimb@redhat.com>, Elena Zannoni <ezannoni@redhat.com>
Subject: [rfa/dwarf] Handle debug_line extended ops correctly
Date: Wed, 16 Jun 2004 15:44:00 -0000	[thread overview]
Message-ID: <20040616154402.GA25649@nevyn.them.org> (raw)

This has been hanging around in my tree for a while.  The HP-UX ia64
compiler generates things like this in .debug_line:
  Extended opcode 32: UNKNOWN: length 51
  Extended opcode 32: UNKNOWN: length 146

146 is different as a byte and as a uleb128, so we get confused.  Of course,
we're going to bail out shortly anyway because we don't accept unknown
extended ops (probably for the best); but we might as well parse the length
right.

OK?

-- 
Daniel Jacobowitz

2004-06-16  Daniel Jacobowitz  <dan@debian.org>

	PR gdb/1658
	* dwarf2read.c (dwarf_decode_lines): Read the length of the extended
	operation as a uleb128.  Found by Michael Coulter.

Index: gdb/dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.153
diff -u -p -r1.153 dwarf2read.c
--- gdb/dwarf2read.c	15 Jun 2004 01:04:19 -0000	1.153
+++ gdb/dwarf2read.c	16 Jun 2004 15:38:49 -0000
@@ -5986,7 +5986,8 @@ dwarf_decode_lines (struct line_header *
 	  else switch (op_code)
 	    {
 	    case DW_LNS_extended_op:
-	      line_ptr += 1;	/* ignore length */
+	      read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
+	      line_ptr += bytes_read;
 	      extended_op = read_1_byte (abfd, line_ptr);
 	      line_ptr += 1;
 	      switch (extended_op)


             reply	other threads:[~2004-06-16 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-16 15:44 Daniel Jacobowitz [this message]
2004-06-16 17:07 ` Jim Blandy
2004-06-16 17:16   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040616154402.GA25649@nevyn.them.org \
    --to=drow@false.org \
    --cc=coulter@cup.hp.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox