From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-33746-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 1139 invoked by alias); 10 Jun 2004 20:04:44 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1084 invoked from network); 10 Jun 2004 20:04:38 -0000
Received: from unknown (HELO lakermmtao01.cox.net) (68.230.240.38)
  by sourceware.org with SMTP; 10 Jun 2004 20:04:38 -0000
Received: from white ([68.9.64.121]) by lakermmtao01.cox.net
          (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP
          id <20040610200439.ELUG18399.lakermmtao01.cox.net@white>
          for <gdb-patches@sources.redhat.com>;
          Thu, 10 Jun 2004 16:04:39 -0400
Received: from bob by white with local (Exim 3.35 #1 (Debian))
	id 1BYVmv-0003Xc-00
	for <gdb-patches@sources.redhat.com>; Thu, 10 Jun 2004 16:04:37 -0400
Date: Thu, 10 Jun 2004 20:04:00 -0000
From: Bob Rossi <bob@brasko.net>
To: gdb-patches@sources.redhat.com
Subject: Re: -file-list-exec-source-files
Message-ID: <20040610200437.GA13464@white>
Mail-Followup-To: gdb-patches@sources.redhat.com
References: <20040506221258.GA7008@white> <20040522015250.GA26435@white> <16572.43047.435129.31640@localhost.redhat.com> <20040601180111.GA2685@white> <16574.9940.867059.792145@localhost.redhat.com> <20040603023521.GA4096@white> <20040609181811.GE11598@white> <20040609184212.GA4007@nevyn.them.org> <20040609191747.GF11598@white> <20040609195739.GA6490@nevyn.them.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040609195739.GA6490@nevyn.them.org>
User-Agent: Mutt/1.3.28i
X-SW-Source: 2004-06/txt/msg00238.txt.bz2

On Wed, Jun 09, 2004 at 03:57:39PM -0400, Daniel Jacobowitz wrote:
> On Wed, Jun 09, 2004 at 03:17:47PM -0400, Bob Rossi wrote:
> > On Wed, Jun 09, 2004 at 02:42:12PM -0400, Daniel Jacobowitz wrote:
> > > On Wed, Jun 09, 2004 at 02:18:11PM -0400, Bob Rossi wrote:
> > > > Ok, I had to make one small change to dwarf2read.c, it was
> > > >    pst->dirname = xstrdup (comp_unit_die.dirname);
> > > > it now is
> > > >    if (comp_unit_die.dirname)
> > > >      pst->dirname = xstrdup (comp_unit_die.dirname);
> > > > 
> > > > This fixed a crash in the testsuite.
> > > 
> > > This sounds OK.
> > 
> > OK.
> > 
> > > > Also, I changed both mi-file.exp and mi2-file.exp from
> > > >    global srcfile
> > > >    global srcdir
> > > >    global subdir
> > > >    set srcfilepath [string_to_regexp ${srcdir}/${subdir}/${srcfile}]
> > > > 
> > > >    "111\\\^done,line=\"23\",file=\"${srcfilepath}\",fullname=...
> > > > 
> > > > to
> > > >    "111\\\^done,line=\"23\",file=\".*/${srcfile}\",fullname=...
> > > > 
> > > > This had nothing to do with this patch. The testcase was failing with a
> > > > clean checkout and run of the testsuite.
> > > 
> > > This is not.  The reason it's failing for you is probably that you
> > > configured in the source directory or using a relative path, right?  Is
> > > it still needed if you configure using an absolute path
> > > (mkdir objdir; cd objdir; /path/to/configure && make && make check) ?
> > 
> > You seem to be correct here. I will not make this change.
> > So otherwise, I'm good to go?
> 
> I think so.

Committed, thanks.

Bob Rossi