From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14828 invoked by alias); 9 Jun 2004 18:18:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14749 invoked from network); 9 Jun 2004 18:18:12 -0000 Received: from unknown (HELO lakermmtao05.cox.net) (68.230.240.34) by sourceware.org with SMTP; 9 Jun 2004 18:18:12 -0000 Received: from white ([68.9.64.121]) by lakermmtao05.cox.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20040609181812.GFYH17850.lakermmtao05.cox.net@white>; Wed, 9 Jun 2004 14:18:12 -0400 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1BY7eN-00036q-00; Wed, 09 Jun 2004 14:18:11 -0400 Date: Wed, 09 Jun 2004 18:18:00 -0000 From: Bob Rossi To: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: -file-list-exec-source-files Message-ID: <20040609181811.GE11598@white> Mail-Followup-To: Elena Zannoni , gdb-patches@sources.redhat.com References: <20040420141001.GB4465@white> <16519.59247.93650.941260@localhost.redhat.com> <20040426130529.GA11975@white> <20040506221258.GA7008@white> <20040522015250.GA26435@white> <16572.43047.435129.31640@localhost.redhat.com> <20040601180111.GA2685@white> <16574.9940.867059.792145@localhost.redhat.com> <20040603023521.GA4096@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040603023521.GA4096@white> User-Agent: Mutt/1.3.28i X-SW-Source: 2004-06/txt/msg00183.txt.bz2 On Wed, Jun 02, 2004 at 10:35:22PM -0400, Bob Rossi wrote: > On Wed, Jun 02, 2004 at 03:13:24PM -0400, Elena Zannoni wrote: > > Bob Rossi writes: > > > > > > The dwarf2 specs say that the name is in the form ":pathname" or > > > "hostname:pathname". Should we worry about the hostname? Does gcc emit > > > that? I have looked at a few executables and didn't see the hostname > > > part. > > > > > > Would you like me to try to take into account the > > > hostname:dirname? Is the hostname allowed to have a ':' in it? > > > > > > > Oh, no. Just the formatting. > > Ok, I'll commit it as soon as I get the chance. Ok, I had to make one small change to dwarf2read.c, it was pst->dirname = xstrdup (comp_unit_die.dirname); it now is if (comp_unit_die.dirname) pst->dirname = xstrdup (comp_unit_die.dirname); This fixed a crash in the testsuite. Also, I changed both mi-file.exp and mi2-file.exp from global srcfile global srcdir global subdir set srcfilepath [string_to_regexp ${srcdir}/${subdir}/${srcfile}] "111\\\^done,line=\"23\",file=\"${srcfilepath}\",fullname=... to "111\\\^done,line=\"23\",file=\".*/${srcfile}\",fullname=... This had nothing to do with this patch. The testcase was failing with a clean checkout and run of the testsuite. Is this OK to commit? If so, I will do it today. Thanks, Bob Rossi