From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29209 invoked by alias); 8 Jun 2004 07:53:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29194 invoked from network); 8 Jun 2004 07:53:49 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sourceware.org with SMTP; 8 Jun 2004 07:53:49 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i587reKV002645; Tue, 8 Jun 2004 09:53:40 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i587rexv007743; Tue, 8 Jun 2004 09:53:40 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i587rdAt007740; Tue, 8 Jun 2004 09:53:39 +0200 (CEST) Date: Tue, 08 Jun 2004 07:53:00 -0000 Message-Id: <200406080753.i587rdAt007740@elgar.kettenis.dyndns.org> From: Mark Kettenis To: hunt@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <1086667710.5507.27.camel@hunt.cipe.redhat.com> Subject: Re: [RFA] dwarf2 read_reg References: <1086667710.5507.27.camel@hunt.cipe.redhat.com> X-SW-Source: 2004-06/txt/msg00151.txt.bz2 From: "Martin M. Hunt" Date: Mon, 07 Jun 2004 21:08:31 -0700 The read_reg() function made an assumption that sizeof pointer was the same as a register size. This broke lots of things for architectures like mips. 2004-05-26 Martin Hunt * dwarf2-frame.c (read_reg): Use register_size() instead of sizeof pointer. And your patch makes the assumption that addresses are signed, which breaks architectures where addesses are unsigned. Mark