From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2351 invoked by alias); 7 Jun 2004 21:58:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2337 invoked from network); 7 Jun 2004 21:58:38 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 7 Jun 2004 21:58:38 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1BXS8b-0002uH-QE; Mon, 07 Jun 2004 17:58:37 -0400 Date: Mon, 07 Jun 2004 21:58:00 -0000 From: Daniel Jacobowitz To: Jeff Johnston Cc: gdb-patches@sources.redhat.com, msnyder@redhat.com Subject: Re: [RFA]: Additional dead thread patch Message-ID: <20040607215837.GA11052@nevyn.them.org> Mail-Followup-To: Jeff Johnston , gdb-patches@sources.redhat.com, msnyder@redhat.com References: <40C4E3EB.1020807@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40C4E3EB.1020807@redhat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-06/txt/msg00141.txt.bz2 On Mon, Jun 07, 2004 at 05:53:47PM -0400, Jeff Johnston wrote: > After updating to current sources today, I have noticed a regression in > print-threads.exp which is due to some missing logic in my June 4th patch. > The problem is a timing issue (it does not occur for my June 4th build). > There is a gdb_assert in thread_from_lwp() which gets triggered because the > th_valid flag has not been set for a zombie thread's thread_info struct. > > This patch fills in the zombie thread's thread_info private area since the > information is indeed valid and available. > > Ok to commit? > > -- Jeff J. > > 2004-06-07 Jeff Johnston > > * thread-db.c (thread_get_info_callback): Fill in the thread_info > struct if one exists, even if we are dealing with a zombie thread. > Yes, this is OK. -- Daniel Jacobowitz