From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8454 invoked by alias); 2 Jun 2004 17:34:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8425 invoked from network); 2 Jun 2004 17:34:38 -0000 Received: from unknown (HELO maynard.mail.mindspring.net) (207.69.200.243) by sourceware.org with SMTP; 2 Jun 2004 17:34:38 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by maynard.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BVZdH-0007wU-00; Wed, 02 Jun 2004 13:34:31 -0400 Received: by berman.michael-chastain.com (Postfix, from userid 502) id E638E4B104; Wed, 2 Jun 2004 13:34:34 -0400 (EDT) To: jjohnstn@redhat.com, msnyder@redhat.com Subject: [rfa/testsuite/threads] ping: manythreads.exp Cc: gdb-patches@sources.redhat.com Message-Id: <20040602173434.E638E4B104@berman.michael-chastain.com> Date: Wed, 02 Jun 2004 17:34:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2004-06/txt/msg00029.txt.bz2 This patch fixes a problem in gdb.threads/manythreads.exp. I've submitted this patch before on 2004-05-07 and 2004-05-14. manythreads.exp uses asynchronous TCL blocks to send "^C" at a later time, similar to the shell code: "(sleep 1 ; send ^C) &". If the tests fail -- and they do sometimes fail -- manythreads.exp leaves these asynchronous blocks in the background, where they ruin the unlucky next test, which happens to be gdb.threads/print-threads.exp. This patch changes the sleeps from asynchronous to synchronous so that there is no cleanup to do: "(sleep 1 ; send ^C)". I tested this (again) on native i686-pc-linux-gnu, red hat 8.0, group of 6 test runs before and after. OK to commit? Michael C 2004-06-02 Michael Chastain Fix PR gdb/1636. * gdb.threads/manythreads.exp: Change asynchronous 'after' calls to synchronous. Index: gdb.threads/manythreads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/manythreads.exp,v retrieving revision 1.1 diff -c -3 -p -r1.1 manythreads.exp *** gdb.threads/manythreads.exp 22 Apr 2004 22:19:40 -0000 1.1 --- gdb.threads/manythreads.exp 7 May 2004 12:41:39 -0000 *************** gdb_test_multiple "continue" "first cont *** 60,66 **** } # Send a Ctrl-C and verify that we can do info threads and continue ! after 1000 {send_gdb "\003"} set message "stop threads 1" gdb_test_multiple "" "stop threads 1" { -re "\\\[New \[^\]\]*\\\]\r\n" { --- 60,67 ---- } # Send a Ctrl-C and verify that we can do info threads and continue ! after 1000 ! send_gdb "\003" set message "stop threads 1" gdb_test_multiple "" "stop threads 1" { -re "\\\[New \[^\]\]*\\\]\r\n" { *************** gdb_test_multiple "continue" "second con *** 93,99 **** } # Send another Ctrl-C and verify that we can do info threads and quit ! after 1000 {send_gdb "\003"} set message "stop threads 2" gdb_test_multiple "" "stop threads 2" { -re "\\\[New \[^\]\]*\\\]\r\n" { --- 94,101 ---- } # Send another Ctrl-C and verify that we can do info threads and quit ! after 1000 ! send_gdb "\003" set message "stop threads 2" gdb_test_multiple "" "stop threads 2" { -re "\\\[New \[^\]\]*\\\]\r\n" {