Re: Configure GDB for MinGW

Manu
2004-05-25T21:32:00Z

Mark Kettenis wrote:

> Thanks for your contribution. I think it is small enough to be
> accepted without a copyright assignment, especially if you follow the
> advice below. I'm not completely sure though.
>
> A few remarks and questions:
>
> 1. Please update the copyright year of new files or files that you
changed.
>
> 2. Please remove any empty variables in your .mh and .mt files.

Ok.

> 3. Is MH_CFLAGS=-D_POSIX in mingw32.mh really necessary?

I need to check that point.

> 4. Your nm-mingw32.h file seems to be a verbatim copy if nm-cygwin.h.
> Please use nm-cygwin.h instead.
>
> 5. All your tm-mingw32.h file does in including tm-cygwin.h. Actually
> I think you can just use cygwin.mt instead of mingw32.mt. I expect
> that MinGW uses the same convention for returning structs as
> Cygwin, so that will actually fix a few bugs.

Agreed.

> 6. Why is the line
>
> #define getkey getch
>
> in xm-mingw32.h needed?

getkey doesn't exist, but getch does.

> 7. Looks like ser-mingw32.c is doing nothing. AFAICT it shouldn't be
> necessary.

It would be for future use.

Thanks for your help, I'll submit a new diff file.

There's a few specific bugs with MinGW versions of GDB.
I hope to "./configure && make" from CVS sources soon, and then to find
out what goes wrong sometimes.

Manu.