Re: Configure GDB for MinGW

Christopher Faylor
2004-05-24T21:01:00Z

On Mon, May 24, 2004 at 07:36:51PM +0200, Mark Kettenis wrote:
> From: "Manu" <manubee@wanadoo.fr>
> Date: Fri, 21 May 2004 12:04:20 +0200
>
>Thanks for your contribution. I think it is small enough to be
>accepted without a copyright assignment, especially if you follow the
>advice below. I'm not completely sure though.

I guess we'd have to see the actual finished patch but given that it makes
changes to a number of files and adds new functionality, I don't think
it really could be considered trivial.

>A few remarks and questions:
>
>1. Please update the copyright year of new files or files that you changed.
>
>2. Please remove any empty variables in your .mh and .mt files.
>
>3. Is MH_CFLAGS=-D_POSIX in mingw32.mh really necessary?
>
>4. Your nm-mingw32.h file seems to be a verbatim copy if nm-cygwin.h.
> Please use nm-cygwin.h instead.

For consistency with gcc, we could rename this file n-cygming.h.

>5. All your tm-mingw32.h file does in including tm-cygwin.h. Actually
> I think you can just use cygwin.mt instead of mingw32.mt. I expect
> that MinGW uses the same convention for returning structs as
> Cygwin, so that will actually fix a few bugs.

Again, the cygwin.mt file could be renamed.

cgf