Re: Configure GDB for MinGW

Mark Kettenis
2004-05-24T17:36:00Z

From: "Manu" <manubee@wanadoo.fr>
Date: Fri, 21 May 2004 12:04:20 +0200

Thanks for your contribution. I think it is small enough to be
accepted without a copyright assignment, especially if you follow the
advice below. I'm not completely sure though.

A few remarks and questions:

1. Please update the copyright year of new files or files that you changed.

2. Please remove any empty variables in your .mh and .mt files.

3. Is MH_CFLAGS=-D_POSIX in mingw32.mh really necessary?

4. Your nm-mingw32.h file seems to be a verbatim copy if nm-cygwin.h.
Please use nm-cygwin.h instead.

5. All your tm-mingw32.h file does in including tm-cygwin.h. Actually
I think you can just use cygwin.mt instead of mingw32.mt. I expect
that MinGW uses the same convention for returning structs as
Cygwin, so that will actually fix a few bugs.

6. Why is the line

#define getkey getch

in xm-mingw32.h needed?

7. Looks like ser-mingw32.c is doing nothing. AFAICT it shouldn't be
necessary.

Cheers,

Mark