From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Faylor To: gdb-patches@sources.redhat.com Cc: manubee@wanadoo.fr Subject: Re: Configure GDB for MinGW Date: Mon, 24 May 2004 21:01:00 -0000 Message-id: <20040524210149.GA11067@coe.bosbc.com> References: <000b01c43f1b$1c595560$e586f8c1@tbird1000> <200405241736.i4OHapkM000351@elgar.kettenis.dyndns.org> X-SW-Source: 2004-05/msg00692.html On Mon, May 24, 2004 at 07:36:51PM +0200, Mark Kettenis wrote: > From: "Manu" > Date: Fri, 21 May 2004 12:04:20 +0200 > >Thanks for your contribution. I think it is small enough to be >accepted without a copyright assignment, especially if you follow the >advice below. I'm not completely sure though. I guess we'd have to see the actual finished patch but given that it makes changes to a number of files and adds new functionality, I don't think it really could be considered trivial. >A few remarks and questions: > >1. Please update the copyright year of new files or files that you changed. > >2. Please remove any empty variables in your .mh and .mt files. > >3. Is MH_CFLAGS=-D_POSIX in mingw32.mh really necessary? > >4. Your nm-mingw32.h file seems to be a verbatim copy if nm-cygwin.h. > Please use nm-cygwin.h instead. For consistency with gcc, we could rename this file n-cygming.h. >5. All your tm-mingw32.h file does in including tm-cygwin.h. Actually > I think you can just use cygwin.mt instead of mingw32.mt. I expect > that MinGW uses the same convention for returning structs as > Cygwin, so that will actually fix a few bugs. Again, the cygwin.mt file could be renamed. cgf