From: Randolph Chung <randolph@tausq.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] function descriptor handling for push_dummy_call
Date: Thu, 20 May 2004 04:40:00 -0000 [thread overview]
Message-ID: <20040520044024.GX566@tausq.org> (raw)
In-Reply-To: <40AB93DC.5080300@gnu.org>
> So they could all, as a mechanical operation, be changed from:
>
> ..._call (..., CORE_ADDR funaddr, ...)
>
> to:
>
> ..._call (..., struct value *function, ...)
> {
> CORE_ADDR funaddr = find_function_addr (function);
>
> (perhaphs make find_function_addr robust to a NULL value_type).
yes, except it's not used in most of the cases.... so i wasn't even
going to add the call, but i can "just to be safe"....
> I was thinking that infcall.c should convert "function" into a proper
> function pointer but this appears just as effective.
>
> I think this is ok.
ok, i will check in after i manage to go change all the targets and run
it through gdb_mbuild.sh..... probably next week. i'll also update
gdbint.texinfo before i check in.
thanks,
randolph
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
prev parent reply other threads:[~2004-05-20 4:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-18 6:12 Randolph Chung
2004-05-19 17:05 ` Andrew Cagney
2004-05-20 4:40 ` Randolph Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040520044024.GX566@tausq.org \
--to=randolph@tausq.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox