Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfa] Handle unwinding through export stubs on hpux
Date: Sat, 15 May 2004 23:58:00 -0000	[thread overview]
Message-ID: <20040515235801.GY566@tausq.org> (raw)

This fixes a problem reported by Dave Anglin; when doing a backtrace
through a function that is called through an export stub, the unwinder
fails. The problem is that the stub unwinder assumes that the return
pointer doesn't change inside the stub, but the export stub changes it.

Possibly something also needs to be changed for an argument relocation
stub. Will investigate and fix that separately if needed.

tested on hppa2.0w-hp-hpux11.11.

ok to apply?

randolph


2004-05-15  Randolph Chung  <tausq@debian.org>

	* hppa-tdep.c (hppa_stub_frame_unwind_cache): For HPUX stub unwinding,
	check to see if we are unwinding an export stub.  Export stubs clobber
	the %rp in the call path and stores the original rp in a stack slot.

Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.156
diff -u -p -u -r1.156 hppa-tdep.c
--- hppa-tdep.c	8 May 2004 03:59:34 -0000	1.156
+++ hppa-tdep.c	15 May 2004 20:54:57 -0000
@@ -2023,6 +2023,7 @@ hppa_stub_frame_unwind_cache (struct fra
 {
   struct gdbarch *gdbarch = get_frame_arch (next_frame);
   struct hppa_stub_unwind_cache *info;
+  struct unwind_table_entry *u;
 
   if (*this_cache)
     return *this_cache;
@@ -2031,8 +2032,19 @@ hppa_stub_frame_unwind_cache (struct fra
   *this_cache = info;
   info->saved_regs = trad_frame_alloc_saved_regs (next_frame);
 
-  info->saved_regs[HPPA_PCOQ_HEAD_REGNUM].realreg = HPPA_RP_REGNUM;
-  info->base = frame_unwind_register_unsigned (next_frame, HPPA_SP_REGNUM);
+  if ((gdbarch_osabi (gdbarch) == GDB_OSABI_HPUX_ELF 
+       || gdbarch_osabi (gdbarch) == GDB_OSABI_HPUX_SOM)
+      && (u = find_unwind_entry (frame_pc_unwind (next_frame)))
+      && (u->stub_unwind.stub_type == EXPORT))
+    {
+      info->base = frame_unwind_register_unsigned (next_frame, HPPA_SP_REGNUM);
+      info->saved_regs[HPPA_PCOQ_HEAD_REGNUM].addr = info->base - 24;
+    }
+  else
+    {
+      info->base = frame_unwind_register_unsigned (next_frame, HPPA_SP_REGNUM);
+      info->saved_regs[HPPA_PCOQ_HEAD_REGNUM].realreg = HPPA_RP_REGNUM;
+    }
 
   return info;
 }

-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


             reply	other threads:[~2004-05-15 23:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15 23:58 Randolph Chung [this message]
2004-05-17 15:09 ` Andrew Cagney
2004-05-17 16:47   ` Randolph Chung
2004-05-17 18:46 John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040515235801.GY566@tausq.org \
    --to=randolph@tausq.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox