Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Randolph Chung <randolph@tausq.org>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfa] Fix trampoline definitions for hppa-linux
Date: Sat, 15 May 2004 03:08:00 -0000	[thread overview]
Message-ID: <20040515030758.GN566@tausq.org> (raw)

The cross-gdb patch I posted earlier had a nasty side effect that it 
overrode some of the trampoline methods set in hppa-linux-tdep.c. This
fixes it. ok to apply? 

It's rather non-obvious that including tm-linux.h will suddenly make
some gdbarch methods not work anymore.... :(

randolph

2004-05-14  Randolph Chung  <tausq@debian.org>

	* config/pa/tm-linux.h (IN_SOLIB_CALL_TRAMPOLINE, SKIP_TRAMPOLINE_CODE)
	Undefine these so we can overide them using gdbarch.

Index: config/pa/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/pa/tm-linux.h,v
retrieving revision 1.1
diff -u -p -r1.1 tm-linux.h
--- config/pa/tm-linux.h	10 May 2004 18:33:37 -0000	1.1
+++ config/pa/tm-linux.h	15 May 2004 03:02:38 -0000
@@ -24,4 +24,10 @@
 #include "pa/tm-hppa.h"
 #include "config/tm-linux.h"
 
+/* Including tm-linux.h indirectly includes tm-sysv4.h which defines
+   the following macros.  We want to use the regular gdbarch mechanism
+   to set the methods in hppa*tdep.c, so undefine them here.  */
+#undef IN_SOLIB_CALL_TRAMPOLINE
+#undef SKIP_TRAMPOLINE_CODE
+
 #endif /* #ifndef TM_LINUX_H */

-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


             reply	other threads:[~2004-05-15  3:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15  3:08 Randolph Chung [this message]
2004-05-17 15:10 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040515030758.GN566@tausq.org \
    --to=randolph@tausq.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox