From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Jacobowitz To: Paul Hilfinger Cc: cagney@gnu.org, jimb@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] Introduce notion of "search name" Date: Thu, 13 May 2004 13:49:00 -0000 Message-id: <20040513134935.GA23751@nevyn.them.org> References: <20040429211458.GB27523@nevyn.them.org> <20040430084538.ECDE1F2E1C@nile.gnat.com> <20040430134955.GA15786@nevyn.them.org> <20040503084937.439F4F2C0A@nile.gnat.com> <20040511194843.GA15952@nevyn.them.org> <20040512105959.806E6F2DE4@nile.gnat.com> <20040512132708.GA25122@nevyn.them.org> <40A2313E.1080100@gnu.org> <20040513093023.9718CF2B55@nile.gnat.com> X-SW-Source: 2004-05/msg00400.html On Thu, May 13, 2004 at 05:30:23AM -0400, Paul Hilfinger wrote: > > Oh great. I walk into my office to find skull fragments all over the > floor, but still no final decision. Ah well. Risking exposure to > stray prions, I submit the latest version of this patch below. > > I am actually sympathetic to Andrew's ideas here, since with some > version of the extra abstraction he suggests, I could avoid all > permanent storage for demangled names. However, it WOULD be a > substantial change and speaking for ACT, we'd really, really first > like to get some substantial portion of the Ada changes integrated > into (and active) in the public GDB version. This patch is OK with me; let's see if Jim likes it. Thanks for following through; you've been a real sport about this. > > Paul Hilfinger > > 2004-05-13 Paul N. Hilfinger > > * symtab.h (SYMBOL_SEARCH_NAME): New definition. > (SYMBOL_MATCHES_SEARCH_NAME): New definition. > (symbol_search_name): Declare. > > * dictionary.c (iter_name_first_hashed): Match on SYMBOL_SEARCH_NAME. > (iter_name_next_hashed): Ditto. > (iter_name_next_linear): Ditto. > (insert_symbol_hashed): Hash on SYMBOL_SEARCH_NAME. > > * symtab.c (lookup_partial_symbol): Assume symbols ordered by > search name, using SYMBOL_SEARCH_NAME and SYMBOL_MATCHES_SEARCH_NAME. > (symbol_search_name): New function. > > * symfile.c (compare_psymbols): Order by SYMBOL_SEARCH_NAME. > > * minsyms.c (build_minimal_symbol_hash_tables): Change > test for adding to demangled hash table to check for difference > between SYMBOL_SEARCH_NAME and SYMBOL_LINKAGE_NAME. -- Daniel Jacobowitz