From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13847 invoked by alias); 7 May 2004 06:14:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13839 invoked from network); 7 May 2004 06:14:23 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 7 May 2004 06:14:23 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BLyco-0002ry-LX; Fri, 07 May 2004 02:14:22 -0400 Date: Fri, 07 May 2004 06:14:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com, msnyder@redhat.com, jjohnstn@redhat.com Subject: Re: [rfa/testsuite/threads] manythreads.exp: cancel outstanding after-blocks Message-ID: <20040507061422.GA29075@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com, msnyder@redhat.com, jjohnstn@redhat.com References: <20040507060902.DF1994B104@berman.michael-chastain.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040507060902.DF1994B104@berman.michael-chastain.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-05/txt/msg00182.txt.bz2 On Fri, May 07, 2004 at 02:09:02AM -0400, Michael Chastain wrote: > [Oops, how about a message body this time!] > > This patch fixes PR gdb/1636, a problem in manythreads.exp. > > http://sources.redhat.com/gdb/bugs/1636 > manythreads.exp issues async ^C that spills onto next script > > manythreads.exp creates some asynchronous blocks for sending ^C at a > later time. This patch simply cancels the blocks before manythreads.exp > exits in case the blocks haven't executed yet. This prevents the async > blocks from hanging around and sending their ^C during the middle of the > next script, print-threads.exp. > > I don't know whether these blocks should be async at all, but I'm not > touching that part. This just keeps print-threads.exp from barfing > during before-and-after runs that I do for any other work. > > I tested this on native i686-pc-linux-gnu, red hat 8.0, with several > gcc's and binutils and both dwarf-2 and stabs+. I did 12 test runs > before and after. About 3-4 of the runs in each test group exhibit > internal errors in gdb which case manythreads.exp to FAIL. I verified > that the next test script, print-threads.exp, was no longer clobbered by > this. > > Okay to commit? > > 2004-05-07 Michael Chastain > > Fix PR gdb/1636. > * gdb.threads/manythreads.exp: Cancel any outstanding after-blocks. That's a nice trick, I didn't know it. But it's simpler to just make the stop synchronous... would you mind trying that instead? -- Daniel Jacobowitz