From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11455 invoked by alias); 6 May 2004 14:21:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11447 invoked from network); 6 May 2004 14:21:50 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 6 May 2004 14:21:50 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BLjkw-0006Pp-Nj; Thu, 06 May 2004 10:21:46 -0400 Date: Thu, 06 May 2004 14:21:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Orjan Friberg , weigand@i1.informatik.uni-erlangen.de, kettenis@chello.nl, gdb-patches@sources.redhat.com Subject: Re: Display of read/access watchpoints when HAVE_NONSTEPPABLE_WATCHPOINT Message-ID: <20040506142146.GA24608@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , Orjan Friberg , weigand@i1.informatik.uni-erlangen.de, kettenis@chello.nl, gdb-patches@sources.redhat.com References: <200405042208.AAA07379@faui1d.informatik.uni-erlangen.de> <4098A4F6.5020106@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-05/txt/msg00151.txt.bz2 On Thu, May 06, 2004 at 07:59:34AM +0200, Eli Zaretskii wrote: > > Date: Wed, 05 May 2004 10:25:26 +0200 > > From: Orjan Friberg > > > > Note that tm-frv.h and nm-hppah.h actually use the struct > > target_waitstatus that is normally passed as an argument to the > > STOPPED_BY_WATCHPOINT macro. > > Thanks for the heads-up. > > Thus, for the STOPPED_BY_WATCHPOINT trick to work, bpstat_stop_status > needs to have access to the relevant parts of the inferior's struct > execution_control_state variable. It doesn't seem to me too hard to > pass that as an additional argument. This is the point where I want to go back to the "design" bit that Mark was talking about. execution_control_state is private to infrun.c, and I would prefer to leave it that way; the more localized it is, the easier it is to clean up and maintain, without having to rip tentacles out of other parts of GDB. -- Daniel Jacobowitz