From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20982 invoked by alias); 4 May 2004 22:03:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20958 invoked from network); 4 May 2004 22:03:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 4 May 2004 22:03:18 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i44M3IkG008783 for ; Tue, 4 May 2004 18:03:18 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i44M3Iv20292 for ; Tue, 4 May 2004 18:03:18 -0400 Received: from localhost.localdomain (vpn50-6.rdu.redhat.com [172.16.50.6]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i44M3HOp012697; Tue, 4 May 2004 18:03:17 -0400 Received: from saguaro (saguaro.lan [192.168.64.2]) by localhost.localdomain (8.12.10/8.12.10) with SMTP id i44M3COR010987; Tue, 4 May 2004 15:03:12 -0700 Date: Tue, 04 May 2004 22:03:00 -0000 From: Kevin Buettner To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: let gdbarch define FP0_REGNUM on rs6000 Message-Id: <20040504150311.3eb35e67@saguaro> In-Reply-To: References: <4097A012.2050409@gnu.org> <20040504090129.74ce59dd@saguaro> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2004-05/txt/msg00121.txt.bz2 On 04 May 2004 15:41:43 -0500 Jim Blandy wrote: > Actually, I'd appreciate a second set of eyes. The patch to > completely remove uses of FP0_REGNUM from RS6000-specific code was > larger than I expected. I proofread your patch. I didn't see any problems. > 2004-05-04 Jim Blandy > > * config/rs6000/tm-rs6000.h (FP0_REGNUM): Document that this > should no longer be used in code specific to the RS6000 and its > derivatives. > * ppc-tdep.h (struct gdbarch_tdep): Add 'ppc_fp0_regnum' member. > * rs6000-tdep.c (rs6000_gdbarch_init): Initialize > tdep->ppc_fp0_regnum. > (ppc_supply_fpregset, ppc_collect_fpregset) > (rs6000_push_dummy_call, rs6000_extract_return_value) > (rs6000_dwarf2_stab_reg_to_regnum, rs6000_store_return_value) > (rs6000_frame_cache): Use tdep->ppc_fp0_regnum instead of > FP0_REGNUM. > * aix-thread.c (supply_fprs, fetch_regs_kernel_thread) > (fill_gprs64, fill_gprs32, fill_fprs, store_regs_kernel_thread): > Same. > * ppc-bdm.c (bdm_ppc_fetch_registers, bdm_ppc_fetch_registers, > bdm_ppc_store_registers): Same. > * ppc-linux-nat.c (ppc_register_u_addr, fetch_register) > (store_register, fill_fpregset): Same. > * ppc-linux-tdep.c (ppc_linux_sigtramp_cache) > (ppc_linux_supply_fpregset): Same. > * ppcnbsd-nat.c (getfpregs_supplies): Same. > * ppcnbsd-tdep.c (ppcnbsd_supply_fpreg, ppcnbsd_fill_fpreg): > Same. > * ppc-sysv-tdep.c (ppc_sysv_abi_push_dummy_call, > do_ppc_sysv_return_value, ppc64_sysv_abi_push_dummy_call, > ppc64_sysv_abi_return_value): Same. > * rs6000-nat.c (regmap, fetch_inferior_registers) > (store_inferior_registers, fetch_core_registers): Same. Okay. Kevin