From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29846 invoked by alias); 4 May 2004 14:10:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29837 invoked from network); 4 May 2004 14:10:30 -0000 Received: from unknown (HELO pippin.tausq.org) (64.81.244.94) by sources.redhat.com with SMTP; 4 May 2004 14:10:30 -0000 Received: by pippin.tausq.org (Postfix, from userid 1000) id C4BDECD28A; Tue, 4 May 2004 07:10:35 -0700 (PDT) Date: Tue, 04 May 2004 14:10:00 -0000 From: Randolph Chung To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc/hppa] handle setting gp for calling shlib functions Message-ID: <20040504141035.GH3965@tausq.org> Reply-To: Randolph Chung References: <20040429062324.GX3965@tausq.org> <40910D4F.1020700@gnu.org> <20040429150704.GZ3965@tausq.org> <409126FD.3080708@gnu.org> <20040429161357.GA3965@tausq.org> <409131F2.5040706@gnu.org> <20040430040417.GC3965@tausq.org> <409261BF.8010605@gnu.org> <4097A2A3.8030807@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4097A2A3.8030807@gnu.org> X-GPG: for GPG key, see http://www.tausq.org/gpg.txt User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-05/txt/msg00094.txt.bz2 > What happens if the function pointer value, rather than code start > address is passed into push dummy call? The entire value should be > passed in, but this is a simple step in that direction. This will certainly help, as long as we also have a hook later in call_function_by_hand () that can twiddle the funcaddr before setting the breakpoint. maybe just moving the call that converts a funcptr to an address to after the push dummy call? btw, a related but slightly different question -- i don't see any code in this path which will preserve and restore the call-clobbered registers when doing a call. how does gdb ensure that the register state before and after the call are the same? (i do see that there is a testcase for this though.) thanks, randolph -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/