From: Kevin Buettner <kevinb@redhat.com>
To: Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: let gdbarch define FP0_REGNUM on rs6000
Date: Tue, 04 May 2004 16:01:00 -0000 [thread overview]
Message-ID: <20040504090129.74ce59dd@saguaro> (raw)
In-Reply-To: <vt27jvs5ik6.fsf@zenia.home>
On 04 May 2004 10:16:25 -0500
Jim Blandy <jimb@redhat.com> wrote:
> > > - #define FP0_REGNUM 32 /* Floating point register 0 */
> >
> > Note that FP0_REGNUM is on the deprecate hit list, it's superseeded by
> > things like reggroups and regsets. As with other code, you should
> > s/FP0_REGNUM/RS6000_FP0_REGNUM/ where possible.
>
> Okay. In the RS6000 case, it'd probably be more consistent to simply
> use tdep->ppc_fp0_regnum, rather than introducing a new macro.
I agree. Consider such a patch to be preapproved.
Kevin
next prev parent reply other threads:[~2004-05-04 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-03 23:55 Jim Blandy
2004-05-04 13:52 ` Andrew Cagney
2004-05-04 15:20 ` Jim Blandy
2004-05-04 16:01 ` Kevin Buettner [this message]
2004-05-04 20:45 ` Jim Blandy
2004-05-04 22:03 ` Kevin Buettner
2004-05-05 1:47 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040504090129.74ce59dd@saguaro \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox