From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15805 invoked by alias); 4 May 2004 00:15:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15792 invoked from network); 4 May 2004 00:15:07 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 4 May 2004 00:15:07 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 7D0A647D64; Mon, 3 May 2004 17:15:07 -0700 (PDT) Date: Tue, 04 May 2004 00:15:00 -0000 From: Joel Brobecker To: Andrew Pinski Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/dwarf-2] Add support for included files Message-ID: <20040504001507.GW16083@gnat.com> References: <6D50AA83-9D4F-11D8-9EB6-000393A6D2F2@physics.uc.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="bKyqfOwhbdpXa4YI" Content-Disposition: inline In-Reply-To: <6D50AA83-9D4F-11D8-9EB6-000393A6D2F2@physics.uc.edu> User-Agent: Mutt/1.4i X-SW-Source: 2004-05/txt/msg00084.txt.bz2 --bKyqfOwhbdpXa4YI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 957 > /home/gates/pinskia/src/gnu/combinesources/src/gdb/dwarf2read.c: In > function `dwarf2_create_include_psymtab': > /home/gates/pinskia/src/gnu/combinesources/src/gdb/dwarf2read.c:1244: > error: invalid lvalue in assignment Sorry about that, this error didn't show up with the compiler I used. I just built one straight from mainline and could reproduce the error. Apparently, expressions like this are not legal? (char *) something = NULL; Anyway, I fixed the immediate problem by expanding the PST_PRIVATE macro into its actual definition, but without the cast. That should allow you to build again. 2004-05-03 Joel Brobecker * dwarf2read.c (dwarf2_create_include_psymtab): Fix build failure detected by recent versions of GCC. (psymtab_to_symtab_1): No longer use the PST_PRIVATE macro to be consistent with the usage in dwarf2_create_include_psymtab. Checked in mainline. -- Joel --bKyqfOwhbdpXa4YI Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="dwarf2read.c.diff" Content-length: 1225 Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.149 diff -u -p -r1.149 dwarf2read.c --- dwarf2read.c 3 May 2004 16:21:50 -0000 1.149 +++ dwarf2read.c 4 May 2004 00:08:10 -0000 @@ -1239,9 +1239,9 @@ dwarf2_create_include_psymtab (char *nam /* No private part is necessary for include psymtabs. This property can be used to differentiate between such include psymtabs and the regular ones. If it ever happens that a regular psymtab can - legitimally have a NULL PST_PRIVATE part, then we'll have to add a + legitimally have a NULL private part, then we'll have to add a dedicated field for that in the dwarf2_pinfo structure. */ - PST_PRIVATE (subpst) = NULL; + subpst->read_symtab_private = NULL; } /* Read the Line Number Program data and extract the list of files @@ -2109,7 +2109,7 @@ psymtab_to_symtab_1 (struct partial_symt psymtab_to_symtab_1 (pst->dependencies[i]); } - if (PST_PRIVATE (pst) == NULL) + if (pst->read_symtab_private == NULL) { /* It's an include file, no symbols to read for it. Everything is in the parent symtab. */ --bKyqfOwhbdpXa4YI--