From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32561 invoked by alias); 3 May 2004 16:25:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32546 invoked from network); 3 May 2004 16:25:04 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 3 May 2004 16:25:04 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id EFAC047D64; Mon, 3 May 2004 09:25:03 -0700 (PDT) Date: Mon, 03 May 2004 16:25:00 -0000 From: Joel Brobecker To: Jim Blandy Cc: Daniel Jacobowitz , Eli Zaretskii , gdb-patches@sources.redhat.com Subject: Re: [RFC/dwarf-2] Add support for included files Message-ID: <20040503162503.GS16083@gnat.com> References: <20040413052021.GA1173@gnat.com> <20040415221338.GF1564@gnat.com> <20040416230825.GK22414@gnat.com> <20040501011418.GG16083@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i X-SW-Source: 2004-05/txt/msg00060.txt.bz2 > Let me make sure I've got it right. When we're calling > dwarf_decode_lines for the partial symbol tables, we never call > dwarf2_start_subfile anyway --- that's for building full symbol tables > --- so the use of 'dirname' in that function doesn't matter. And > since it's never used to compute the full name of the symtabs, it > doesn't introduce inconsistencies to omit it. That's right. I updated a bit the comment for that function to include this information. I think it was worthwhile. Here is the new comment describing the function. If you think any change needs to be made, let me know, I'll gladly make them. 2. If PST is not NULL, this procedure reads the program to determine the list of files included by the unit represented by PST, and builds all the associated partial symbol tables. In this case, the value of COMP_DIR is ignored, and can thus be NULL (the COMP_DIR is not used to compute the full name of the symtab, and therefore omitting it when building the partial symtab does not introduce the potential for inconsistency - a partial symtab and its associated symbtab having a different fullname -). */ > If that's correct, then this patch is ready to commit. Thanks very > much! Thanks a lot! This patch is now in. -- Joel