From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23064 invoked by alias); 30 Apr 2004 20:19:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23048 invoked from network); 30 Apr 2004 20:19:13 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.77.109) by sources.redhat.com with SMTP; 30 Apr 2004 20:19:13 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i3UKJCd8000487; Fri, 30 Apr 2004 22:19:12 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i3UKJCoX000559; Fri, 30 Apr 2004 22:19:12 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i3UKJCG4000556; Fri, 30 Apr 2004 22:19:12 +0200 (CEST) Date: Fri, 30 Apr 2004 20:19:00 -0000 Message-Id: <200404302019.i3UKJCG4000556@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ford@vss.fsi.com CC: gdb-patches@sources.redhat.com In-reply-to: (message from Brian Ford on Tue, 20 Apr 2004 11:30:22 -0500) Subject: Re: [PATCH] Proper _to_regnum for DWARF on Cygwin References: X-SW-Source: 2004-04/txt/msg00713.txt.bz2 Date: Tue, 20 Apr 2004 11:30:22 -0500 From: Brian Ford Oops, missed the comment refering to the removed function. Updated patch attached. ChangeLog unchanged from below. Ok to apply? Yes, please add yourself to the MAINTERS file under "Write After Approval". After you've done so, please check in the patch seperately. Cheers, Mark On Mon, 19 Apr 2004, Brian Ford wrote: > On Mon, 19 Apr 2004, Mark Kettenis wrote: > > > Hmm. I very much agree with what Brian wrote in his follow-up > > messages. I think DJGPP is doing the right thing using the SVR4 > > scheme for DWARF2 while staying backwards compatible for stabs. I'd > > advise him to do the same for cygwin. > > Ok, do I need approval to revert my own patch ;-) ? > > 2004-04-19 Brian Ford > > Revert 2004-04-16 change. > * i386-tdep.c (i386_gdbarch_init): Fix comment typos. > (i386_coff_init_abi): Remove. > * i386-tdep.h (i386_coff_init_abi): Remove. > * i386-cygwin-tdep.c (i386_cygwin_init_abi): Remove call to above. > > > If i386_coff_init_abi will be gone, the comments aren't contradictiory > > anymore.