From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2317 invoked by alias); 29 Apr 2004 21:12:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2309 invoked from network); 29 Apr 2004 21:12:39 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 29 Apr 2004 21:12:39 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BJIph-0007Bw-Hs; Thu, 29 Apr 2004 17:12:37 -0400 Date: Thu, 29 Apr 2004 21:12:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Manoj Iyer , gdb-patches@sources.redhat.com Subject: Re: [PATCH] use CFLAGS when compiling (PPC64) Message-ID: <20040429211236.GA27523@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Manoj Iyer , gdb-patches@sources.redhat.com References: <40912759.1080706@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40912759.1080706@gnu.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00692.txt.bz2 On Thu, Apr 29, 2004 at 12:03:37PM -0400, Andrew Cagney wrote: > >This patch add CFLAGS to the compile line for building gdbserver, > >gdbreplay and tclsh. Compiling GDB as 64bit binary on PPC64 breaks without > >this. > > Daniel, did this get rejected? I recall it being pointed out that the > correct way to build such a beastie was with: > > CC='gcc -m64' ./configure && gmake > > and I know that already works. It wasn't rejected but I think it should be. It seems reasonable, but if something needs to be added to link command lines, it should be in $CC or in $LDFLAGS. I don't know what the GNU coding standards have to say about that, though - just my opinion. > >diff -Naurd old/src/gdb/gdbserver/Makefile.in > >new/src/gdb/gdbserver/Makefile.in > >--- old/src/gdb/gdbserver/Makefile.in 2004-03-04 16:59:10.000000000 -0500 > >+++ new/src/gdb/gdbserver/Makefile.in 2004-04-07 15:04:06.398979032 -0500 > >@@ -171,12 +171,12 @@ > > > > gdbserver: $(OBS) ${ADD_DEPS} ${CDEPS} > > rm -f gdbserver > >- ${CC-LD} $(GLOBAL_CFLAGS) $(LDFLAGS) -o gdbserver $(OBS) \ > >+ ${CC-LD} $(GLOBAL_CFLAGS) $(CFLAGS) $(LDFLAGS) -o gdbserver $(OBS) \ > > $(GDBSERVER_LIBS) $(XM_CLIBS) > > > > gdbreplay: gdbreplay.o > > rm -f gdbreplay > >- ${CC-LD} $(GLOBAL_CFLAGS) $(LDFLAGS) -o gdbreplay gdbreplay.o \ > >+ ${CC-LD} $(GLOBAL_CFLAGS) $(CFLAGS) $(LDFLAGS) -o gdbreplay > >gdbreplay.o \ > > $(XM_CLIBS) > > > > # Put the proper machine-specific files first, so M-. on a machine > >diff -Naurd old/src/tcl/unix/Makefile.in new/src/tcl/unix/Makefile.in > >--- old/src/tcl/unix/Makefile.in 2003-01-21 14:40:18.000000000 -0500 > >+++ new/src/tcl/unix/Makefile.in 2004-04-07 15:05:09.046041896 -0500 > >@@ -477,7 +477,7 @@ > > > > > > tclsh: ${TCLSH_OBJS} ${TCL_LIB_FILE} > >- ${CC} ${LDFLAGS} ${TCLSH_OBJS} @TCL_BUILD_LIB_SPEC@ ${LIBS} \ > >+ ${CC} ${CFLAGS} ${LDFLAGS} ${TCLSH_OBJS} @TCL_BUILD_LIB_SPEC@ > >${LIBS} \ > > ${CC_SEARCH_FLAGS} -o tclsh > > > > # Resetting the LIB_RUNTIME_DIR below is required so that > > -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer