[RFA] powerpc - extract a float return value

[Jerome Guitton <guitton@act-europe.fr>]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Hello GDB folks,

The way GDB extracts float return values in rs6000-tdep.c
(rs6000_extract_return_value) seems dubious to me:

[...]
memcpy (&dd, &regbuf[DEPRECATED_REGISTER_BYTE (FP0_REGNUM + 1)], 8);
ff = (float) dd;
memcpy (valbuf, &ff, sizeof (float));
[...]

The cast will not work properly if the target and the host have not a similar
float representation.

I propose to fix that by a call to convert_typed_floating. See patch in
attachment.

I have not yet tested it against the testsuite, I will do that
tomorrow. In the meantime, if you have comments I would be happy to
address them!

--
Jerome

[-- Attachment #2: diff.2 --]
[-- Type: text/plain, Size: 1301 bytes --]

2004-04-20  Jerome Guitton  <guitton@gnat.fr>

	* rs6000-tdep.c (rs6000_extract_return_value): When extracting a float,
	use convert_typed_floating to get the appropriate format.

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.191
diff -u -p -r1.191 rs6000-tdep.c
--- rs6000-tdep.c	1 Apr 2004 21:00:59 -0000	1.191
+++ rs6000-tdep.c	20 Apr 2004 17:45:24 -0000
@@ -1251,8 +1251,6 @@ rs6000_extract_return_value (struct type
   if (TYPE_CODE (valtype) == TYPE_CODE_FLT)
     {
 
-      double dd;
-      float ff;
       /* floats and doubles are returned in fpr1. fpr's have a size of 8 bytes.
          We need to truncate the return value into float size (4 byte) if
          necessary.  */
@@ -1263,9 +1261,11 @@ rs6000_extract_return_value (struct type
 		TYPE_LENGTH (valtype));
       else
 	{			/* float */
-	  memcpy (&dd, &regbuf[DEPRECATED_REGISTER_BYTE (FP0_REGNUM + 1)], 8);
-	  ff = (float) dd;
-	  memcpy (valbuf, &ff, sizeof (float));
+	  convert_typed_floating (&regbuf[DEPRECATED_REGISTER_BYTE
+                                          (FP0_REGNUM + 1)],
+				  builtin_type_double,
+				  valbuf,
+				  valtype);
 	}
     }
   else if (TYPE_CODE (valtype) == TYPE_CODE_ARRAY