From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24220 invoked by alias); 20 Apr 2004 16:35:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24205 invoked from network); 20 Apr 2004 16:35:08 -0000 Received: from unknown (HELO timesys.com) (66.30.22.40) by sources.redhat.com with SMTP; 20 Apr 2004 16:35:08 -0000 Received: by timesys.com (Postfix, from userid 201) id 9D096400016; Tue, 20 Apr 2004 12:35:07 -0400 (EDT) Date: Tue, 20 Apr 2004 16:35:00 -0000 From: Christopher Faylor To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Various Windows support changes Message-ID: <20040420163507.GB22971@coe.bosbc.com> Mail-Followup-To: gdb-patches@sources.redhat.com References: <3271DBB88437ED41A0AB239E6C2554A4031CE230@ussunm001.palmsource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3271DBB88437ED41A0AB239E6C2554A4031CE230@ussunm001.palmsource.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-04/txt/msg00466.txt.bz2 On Mon, Apr 19, 2004 at 04:37:00PM -0700, Keith Rollin wrote: >Hello, > >These patches add some features and fix some bugs in gdb when running under Windows. The enclosed archive the following files requested by the gdb CONTRIBUTING file: > > CHANGES: a description of the changes provided by the patch > ChangeLog: a detailed list of changes in ChangeLog format > gdb-6.0.diff: the patch There is a lot of good work here and most of it looks worthwhile. A few points: 1) It is a fairly large patch involving a few distinct fixes. It is much easier to review and install one patch which addresses one problem than it is to review one gigantic patch which addresses n problems. Would you consider sending this as multiple patches? 2) Please don't send compressed patches here. Just send your patch and ChangeLog as plain text. 3) Please send patches against CVS rather than a gdb release. Patches generated against CVS are more likely to apply cleanly. As it turns out, your patch installed ok with the exception of your change to version.in. However, it is always a little more comforting to see a patch apply without the fuzz and offset warnings from patch. 4) It doesn't look like Palm has an assignment with the FSF. Jim? Can you send him an assignment form? 5) The ChangeLog is a little non-standard. Please use capitalization and present tense, i.e., "Add TEMP and TMP" rather than "added TEMP and TEMP". I do appreciate all of the work that went into this patch. The only real stumbling block here is the lack of an FSF assignment. cgf