From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5836 invoked by alias); 19 Apr 2004 17:18:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5828 invoked from network); 19 Apr 2004 17:18:25 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 19 Apr 2004 17:18:25 -0000 Received: from drow by nevyn.them.org with local (Exim 4.32 #1 (Debian)) id 1BFcPW-0001H1-8t; Mon, 19 Apr 2004 13:18:22 -0400 Date: Mon, 19 Apr 2004 17:18:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [RFA] New dwarf2_attribute_true_p function in dwarf2read.c (take 2) Message-ID: <20040419171821.GA16454@nevyn.them.org> Mail-Followup-To: Joel Brobecker , Jim Blandy , gdb-patches@sources.redhat.com References: <20040416212108.GJ22414@gnat.com> <20040419170932.GW22414@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040419170932.GW22414@gnat.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00429.txt.bz2 On Mon, Apr 19, 2004 at 10:09:32AM -0700, Joel Brobecker wrote: > > > 2004-04-16 Joel Brobecker > > > > > > * dwarf2read.c (dwarf2_attribute_true_p): New function. > > > (die_is_declaration): Use the function above. Add some comments. > > > > > > Tested on x86-linux, no regression. > > > > > > OK to apply? > > > > I'd like the comment for dwarf2_attribute_true_p to specifically say > > that it's meant for use with attributes with DW_FORM_flag values. > > > > (Trying to read more carefully this time...) Looks okay, otherwise. > > I can add a comment, or if you prefer, I can change the name to make > it more explicit. Something like "form_flag_attribute_true_p", for > instance, or "dw_form_flag_attribute_true_p". How about dwarf2_flag_true_p? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer