From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26679 invoked by alias); 17 Apr 2004 16:43:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26672 invoked from network); 17 Apr 2004 16:43:03 -0000 Received: from unknown (HELO pippin.tausq.org) (64.81.244.94) by sources.redhat.com with SMTP; 17 Apr 2004 16:43:03 -0000 Received: by pippin.tausq.org (Postfix, from userid 1000) id 52FC6CD29F; Sat, 17 Apr 2004 10:20:27 -0700 (PDT) Date: Sat, 17 Apr 2004 16:43:00 -0000 From: Randolph Chung To: gdb-patches@sources.redhat.com Subject: Re: [patch] Fix unwind handling for hppa Message-ID: <20040417172027.GD17842@tausq.org> Reply-To: Randolph Chung References: <20040417080536.GB17842@tausq.org> <20040417163525.GA3521@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040417163525.GA3521@nevyn.them.org> X-GPG: for GPG key, see http://www.tausq.org/gpg.txt User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00392.txt.bz2 > > + if (frame_relative_level (next_frame) >= 0 || > > + frame_pc_unwind (next_frame) >= > > + hppa_skip_prologue (frame_func_unwind (next_frame))) > > - your formatting is wrong; operators always come at the beginning > of the line. ok, i have to go and read the coding style doc some more since it is very different from what i'm used to :) > - Checking the frame level is wrong. It's wrong both in practice and > in principle: in practice, the next frame could be a dummy frame > or a signal frame. There's a test case in the testsuite which > covers this. mmmm, ok. so if i just do: if (frame_pc_unwind (next_frame) >= hppa_skip_prologue (frame_func_unwind (next_frame))) then it's ok? or is there a more efficient/correct mechanism to get to this info? thanks, randolph -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/