From: Mark Kettenis <kettenis@chello.nl>
To: cagney@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC] Work around GCC compiler bugs in frame.c
Date: Sat, 17 Apr 2004 15:13:00 -0000 [thread overview]
Message-ID: <200404171513.i3HFD5YP047407@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <407EF6E4.3000306@gnu.org> (message from Andrew Cagney on Thu, 15 Apr 2004 16:56:04 -0400)
Date: Thu, 15 Apr 2004 16:56:04 -0400
From: Andrew Cagney <cagney@gnu.org>
> I've always considered functions return a struct (as opposed to a
> pointer to a struct) bad programming style, but now I know why. The
> following code in frame.c triggers a bug in the system compiler on
> OpenBSD/vax (which is basically GCC 2.95.3 with some local patches):
>
> && frame_id_eq (get_frame_id (this_frame),
> get_frame_id (this_frame->next))
Would introducing frame_eq(), frame_inner() be more robust? Either way
you'll likely want to add a comment.
That would make sense I guess. It's the frame that we care about, not
the ID. I'll check wrap something up...
Mark
prev parent reply other threads:[~2004-04-17 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-15 16:37 Mark Kettenis
2004-04-15 20:56 ` Andrew Cagney
2004-04-17 15:13 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404171513.i3HFD5YP047407@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox