From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10776 invoked by alias); 16 Apr 2004 21:04:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10737 invoked from network); 16 Apr 2004 21:04:14 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 16 Apr 2004 21:04:14 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 3BEBF47D63; Fri, 16 Apr 2004 14:04:14 -0700 (PDT) Date: Fri, 16 Apr 2004 21:04:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: build failure due to observer.sh Message-ID: <20040416210414.GI22414@gnat.com> References: <20040416163944.GS1131@gnat.com> <408032C5.9040104@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="lCAWRPmW1mITcIfM" Content-Disposition: inline In-Reply-To: <408032C5.9040104@gnu.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00373.txt.bz2 --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1067 > I don't think so, just sounds like it isn't a common extension, do the > comments need to be in column one? Moving the comments to column one seems to be fixing the problem. I tested the attached patch on ppc-aix 5.1 (/usr/bin/sed), alpha-tru64 5.1 (/usr/bin/sed), and solaris 2.5+2.8 (usr/xpg4/bin/sed). It worked in all cases. > Having this built on-demand is one of the departures from gdbarch.sh > (and why I committed this now, so early in a release cycle). I'd like > to see how unfixable the problem is before abandoning the idea. OK. I tend to prefer to have all files under revision control, generated files included. That's because when somebody tells us about a problem, we are certain about the sources he used. If some of the files are generated on demand, then we have to consider the possibility of him having experienced a problem during the generation. Hardly an important issue, though. 2004-04-16 Joel Brobecker * observer.sh: Move comments in sed command to first column. Ok to apply? Thanks, -- Joel --lCAWRPmW1mITcIfM Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="observer.sh.diff" Content-length: 1331 Index: observer.sh =================================================================== RCS file: /cvs/src/src/gdb/observer.sh,v retrieving revision 1.1 diff -u -p -r1.1 observer.sh --- observer.sh 15 Apr 2004 14:29:20 -0000 1.1 +++ observer.sh 16 Apr 2004 20:39:48 -0000 @@ -62,22 +62,22 @@ esac IFS=: sed -n ' /@deftypefun void/{ - # Save original line for later processing into the actual parameter +# Save original line for later processing into the actual parameter h - # Convert from: @deftypefun void EVENT (TYPE @var{PARAM},...) - # to event and formals: EVENT:TYPE PARAM, ...: +# Convert from: @deftypefun void EVENT (TYPE @var{PARAM},...) +# to event and formals: EVENT:TYPE PARAM, ...: s/^.* void \([a-z_][a-z_]*\) (\(.*\))$/\1:\2/ s/@var{//g s/}//g - # Switch to held +# Switch to held x - # Convert from: @deftypefun void FUNC (TYPE @var{PARAM},...) - # to actuals: PARAM, ... +# Convert from: @deftypefun void FUNC (TYPE @var{PARAM},...) +# to actuals: PARAM, ... s/^[^{]*[{]*// s/[}]*[^}]*$// s/}[^{]*{/, /g - # Combine held (EVENT:TYPE PARAM, ...:) and pattern (PARAM, ...) into - # FUNC:TYPE PARAM, ...:PARAM, ... +# Combine held (EVENT:TYPE PARAM, ...:) and pattern (PARAM, ...) into +# FUNC:TYPE PARAM, ...:PARAM, ... H x s/\n/:/g --lCAWRPmW1mITcIfM--