Re: [patch] fix unwind handling on hppa elf targets

Joel Brobecker
2004-04-12T01:19:26Z

> i've done some testing. any particular scenario you want me to test?
> there are hundreds of test failures on hppa (hpux and linux) so it's
> difficult to use that to gauge a patch,

I know, but I'd like to avoid that number of failures to grow, so I
really think rerunning the testsuite at each patch is useful.

> I should also point out that i only test against gcc/binutils. if you
> are interested in hpux toolchain please give that a spin.

I don't have access to the HPUX tools, so I also test using GCC/GNAT
too. Michael Chastain, on the other hand, has been giving this
combination several spins. He sends his results from time to time.

Anyway: I verified your patch against the testsuite on HPUX 11 with
both 32bits and 64bits modes. No regression reported. I should note
that I had to modify your patch for two things:

- zero initialize the tdep structure, but allocation using XZALLOC
instead of the XMALLOC macro.

- Tweak the patch to add a #include of hppa-tdep.h in
hppa-hpux-tdep.c. Your patch seems to be dependent on another
patch which I wasn't able to locate in the gdb-patches archives.
So I just did this tweak which was good enough for my purpose.
(oh, and the patch to hppa-tdep.h didn't apply cleanly either -
for the same reason I would imagine)

(I should also add that I couldn't review your patch, not enough
knowledge about hppa/hpux and not enough time right now to study it.
I hope somebody else will be able to help you there).

--
Joel