Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] fix unwind handling on hppa elf targets
Date: Mon, 12 Apr 2004 01:19:00 -0000	[thread overview]
Message-ID: <20040412011924.GL1114@gnat.com> (raw)
In-Reply-To: <20040410180956.GC31873@tausq.org>

> i've done some testing. any particular scenario you want me to test?
> there are hundreds of test failures on hppa (hpux and linux) so it's
> difficult to use that to gauge a patch,

I know, but I'd like to avoid that number of failures to grow, so I
really think rerunning the testsuite at each patch is useful.

> I should also point out that i only test against gcc/binutils. if you
> are interested in hpux toolchain please give that a spin.

I don't have access to the HPUX tools, so I also test using GCC/GNAT
too.  Michael Chastain, on the other hand, has been giving this
combination several spins. He sends his results from time to time.

Anyway: I verified your patch against the testsuite on HPUX 11 with
both 32bits and 64bits modes. No regression reported. I should note
that I had to modify your patch for two things:
  
  - zero initialize the tdep structure, but allocation using XZALLOC
    instead of the XMALLOC macro.

  - Tweak the patch to add a #include of hppa-tdep.h in
    hppa-hpux-tdep.c. Your patch seems to be dependent on another
    patch which I wasn't able to locate in the gdb-patches archives.
    So I just did this tweak which was good enough for my purpose.
    (oh, and the patch to hppa-tdep.h didn't apply cleanly either -
    for the same reason I would imagine)

(I should also add that I couldn't review your patch, not enough
knowledge about hppa/hpux and not enough time right now to study it.
I hope somebody else will be able to help you there).

-- 
Joel


  reply	other threads:[~2004-04-12  1:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-10  9:02 Randolph Chung
2004-04-10 16:57 ` Joel Brobecker
2004-04-10 17:00   ` Randolph Chung
2004-04-10 17:20     ` Joel Brobecker
2004-04-10 17:25       ` Randolph Chung
2004-04-12  1:19         ` Joel Brobecker [this message]
2004-04-12  1:26           ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040412011924.GL1114@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox