From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5576 invoked by alias); 9 Apr 2004 05:38:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5566 invoked from network); 9 Apr 2004 05:38:11 -0000 Received: from unknown (HELO pippin.tausq.org) (64.81.244.94) by sources.redhat.com with SMTP; 9 Apr 2004 05:38:11 -0000 Received: by pippin.tausq.org (Postfix, from userid 1000) id B1E4FCD2C9; Thu, 8 Apr 2004 23:06:18 -0700 (PDT) Date: Fri, 09 Apr 2004 05:38:00 -0000 From: Randolph Chung To: gdb-patches@sources.redhat.com Subject: Re: [patch] more hppa cleanups :) Message-ID: <20040409060618.GP750@tausq.org> Reply-To: Randolph Chung References: <20040409055922.GO750@tausq.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040409055922.GO750@tausq.org> X-GPG: for GPG key, see http://www.tausq.org/gpg.txt User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-04/txt/msg00211.txt.bz2 In reference to a message from Randolph Chung, dated Apr 08: > Nothing exciting, just more cleanups :) ok to commit? sorry, that was the wrong patch. please consider this one instead. 2004-04-08 Randolph Chung * hppa-tdep.c (hppa_reg_struct_has_addr): Rename to hppa_use_struct_convention. (hppa_skip_prologue, hppa_skip_trampoline_code, hppa_in_solib_call_trampoline, hppa_in_solib_return_trampoline, hppa_cannot_store_register, hppa_smash_text_address, hppa_target_read_pc, hppa_target_write_pc): Make static. (hppa_gdbarch_init): Set gdbarch_use_struct_convention --- gdb/gdb/hppa-tdep.c.orig2 2004-04-08 22:03:40.896087672 -0700 +++ gdb/gdb/hppa-tdep.c 2004-04-08 22:35:51.834540408 -0700 @@ -123,17 +123,8 @@ static void record_text_segment_lowaddr (bfd *, asection *, void *); /* FIXME: brobecker 2002-11-07: We will likely be able to make the following functions static, once we hppa is partially multiarched. */ -int hppa_reg_struct_has_addr (int gcc_p, struct type *type); -CORE_ADDR hppa_skip_prologue (CORE_ADDR pc); -CORE_ADDR hppa_skip_trampoline_code (CORE_ADDR pc); -int hppa_in_solib_call_trampoline (CORE_ADDR pc, char *name); -int hppa_in_solib_return_trampoline (CORE_ADDR pc, char *name); int hppa_pc_requires_run_before_use (CORE_ADDR pc); int hppa_instruction_nullified (void); -int hppa_cannot_store_register (int regnum); -CORE_ADDR hppa_smash_text_address (CORE_ADDR addr); -CORE_ADDR hppa_target_read_pc (ptid_t ptid); -void hppa_target_write_pc (CORE_ADDR v, ptid_t ptid); /* Handle 32/64-bit struct return conventions. */ @@ -1006,7 +997,7 @@ /* Get the PC from %r31 if currently in a syscall. Also mask out privilege bits. */ -CORE_ADDR +static CORE_ADDR hppa_target_read_pc (ptid_t ptid) { int flags = read_register_pid (FLAGS_REGNUM, ptid); @@ -1023,7 +1014,7 @@ /* Write out the PC. If currently in a syscall, then also write the new PC value into %r31. */ -void +static void hppa_target_write_pc (CORE_ADDR v, ptid_t ptid) { int flags = read_register_pid (FLAGS_REGNUM, ptid); @@ -1080,7 +1071,7 @@ Note we return one for *any* call trampoline (long-call, arg-reloc), not just shared library trampolines (import, export). */ -int +static int hppa_in_solib_call_trampoline (CORE_ADDR pc, char *name) { struct minimal_symbol *minsym; @@ -1241,7 +1232,7 @@ Note we return one for *any* call trampoline (long-call, arg-reloc), not just shared library trampolines (import, export). */ -int +static int hppa_in_solib_return_trampoline (CORE_ADDR pc, char *name) { struct unwind_table_entry *u; @@ -1314,7 +1305,7 @@ calling an argument relocation stub. It even handles some stubs used in dynamic executables. */ -CORE_ADDR +static CORE_ADDR hppa_skip_trampoline_code (CORE_ADDR pc) { long orig_pc = pc; @@ -1996,7 +1987,7 @@ Currently we must not skip more on the alpha, but we might the lenient stuff some day. */ -CORE_ADDR +static CORE_ADDR hppa_skip_prologue (CORE_ADDR pc) { unsigned long inst; @@ -2440,8 +2431,8 @@ /* We can leave the tail's space the same, since there's no jump. */ } -int -hppa_reg_struct_has_addr (int gcc_p, struct type *type) +static int +hppa_use_struct_convention (int gcc_p, struct type *type) { /* On the PA, any pass-by-value structure > 8 bytes is actually passed via a pointer regardless of its type or the compiler used. */ @@ -2515,7 +2506,7 @@ /* Return True if REGNUM is not a register available to the user through ptrace(). */ -int +static int hppa_cannot_store_register (int regnum) { return (regnum == 0 @@ -2525,7 +2516,7 @@ } -CORE_ADDR +static CORE_ADDR hppa_smash_text_address (CORE_ADDR addr) { /* The low two bits of the PC on the PA contain the privilege level. @@ -2669,6 +2660,8 @@ set_gdbarch_read_pc (gdbarch, hppa_target_read_pc); set_gdbarch_write_pc (gdbarch, hppa_target_write_pc); + set_gdbarch_use_struct_convention (gdbarch, hppa_use_struct_convention); + /* Helper for function argument information. */ set_gdbarch_fetch_pointer_argument (gdbarch, hppa_fetch_pointer_argument);