Re: [PATCH] add-symbol-file-from-memory command

Roland McGrath
2004-04-08T22:28:01Z

> - Would it work to completely replace
> symbol_file_add_with_addrs_or_offsets's 'name' argument with the
> abfd argument, and then just use bfd_get_filename? It looks to me
> like the only affect would be that the tilde-expanded, path-searched
> filename would appear in messages, which seems like a good thing.

I don't see any problem with this. I intentionally did not perturb other
callers, but it would be a simple change to have them call symfile_bfd_open
in their args.

> - Since the command isn't something that ordinary users are really
> going to want themselves, but is more for the benefit of GDB
> developers, should be a 'maint' subcommand?

I think it's in the same category of usefulness as add-symbol-file.

Thanks,
Roland