From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22449 invoked by alias); 8 Apr 2004 22:32:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22441 invoked from network); 8 Apr 2004 22:32:40 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 8 Apr 2004 22:32:40 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1BBi4e-00009V-HK; Thu, 08 Apr 2004 18:32:40 -0400 Date: Thu, 08 Apr 2004 22:32:00 -0000 From: Daniel Jacobowitz To: Roland McGrath Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: [PATCH] add-symbol-file-from-memory command Message-ID: <20040408223240.GB32726@nevyn.them.org> Mail-Followup-To: Roland McGrath , Jim Blandy , gdb-patches@sources.redhat.com References: <200404082227.i38MRwd5011060@magilla.sf.frob.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200404082227.i38MRwd5011060@magilla.sf.frob.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-04/txt/msg00201.txt.bz2 On Thu, Apr 08, 2004 at 03:27:58PM -0700, Roland McGrath wrote: > > - Would it work to completely replace > > symbol_file_add_with_addrs_or_offsets's 'name' argument with the > > abfd argument, and then just use bfd_get_filename? It looks to me > > like the only affect would be that the tilde-expanded, path-searched > > filename would appear in messages, which seems like a good thing. > > I don't see any problem with this. I intentionally did not perturb other > callers, but it would be a simple change to have them call symfile_bfd_open > in their args. I like Jim's suggestion, since the wrong error messages have really bugged me. OTOH, this won't fix all of them - "name" is still used in symfile_bfd_open to print some errors. But progress... > > - Since the command isn't something that ordinary users are really > > going to want themselves, but is more for the benefit of GDB > > developers, should be a 'maint' subcommand? > > I think it's in the same category of usefulness as add-symbol-file. Me, too. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer