From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17440 invoked by alias); 8 Apr 2004 22:28:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17433 invoked from network); 8 Apr 2004 22:28:00 -0000 Received: from unknown (HELO gateway.sf.frob.com) (64.81.54.130) by sources.redhat.com with SMTP; 8 Apr 2004 22:28:00 -0000 Received: from magilla.sf.frob.com (magilla.sf.frob.com [198.49.250.228]) by gateway.sf.frob.com (Postfix) with ESMTP id 92467357B; Thu, 8 Apr 2004 15:27:59 -0700 (PDT) Received: from magilla.sf.frob.com (localhost.localdomain [127.0.0.1]) by magilla.sf.frob.com (8.12.9/8.12.9) with ESMTP id i38MRxOi011064; Thu, 8 Apr 2004 15:27:59 -0700 Received: (from roland@localhost) by magilla.sf.frob.com (8.12.9/8.12.9/Submit) id i38MRwd5011060; Thu, 8 Apr 2004 15:27:58 -0700 Date: Thu, 08 Apr 2004 22:28:00 -0000 Message-Id: <200404082227.i38MRwd5011060@magilla.sf.frob.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] add-symbol-file-from-memory command In-Reply-To: Jim Blandy's message of , 8 April 2004 17:10:57 -0500 Emacs: there's a reason it comes with a built-in psychotherapist. X-SW-Source: 2004-04/txt/msg00199.txt.bz2 > - Would it work to completely replace > symbol_file_add_with_addrs_or_offsets's 'name' argument with the > abfd argument, and then just use bfd_get_filename? It looks to me > like the only affect would be that the tilde-expanded, path-searched > filename would appear in messages, which seems like a good thing. I don't see any problem with this. I intentionally did not perturb other callers, but it would be a simple change to have them call symfile_bfd_open in their args. > - Since the command isn't something that ordinary users are really > going to want themselves, but is more for the benefit of GDB > developers, should be a 'maint' subcommand? I think it's in the same category of usefulness as add-symbol-file. Thanks, Roland