From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13572 invoked by alias); 6 Apr 2004 23:24:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13549 invoked from network); 6 Apr 2004 23:24:54 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.114.7) by sources.redhat.com with SMTP; 6 Apr 2004 23:24:54 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i36NOf0J000243; Wed, 7 Apr 2004 01:24:41 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i36NOfkF001066; Wed, 7 Apr 2004 01:24:41 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i36NOeA9001063; Wed, 7 Apr 2004 01:24:40 +0200 (CEST) Date: Tue, 06 Apr 2004 23:24:00 -0000 Message-Id: <200404062324.i36NOeA9001063@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ford@vss.fsi.com CC: jimb@redhat.com, eliz@gnu.org, gdb-patches@sources.redhat.com In-reply-to: (message from Brian Ford on Mon, 5 Apr 2004 18:19:09 -0500 (CDT)) Subject: Re: [PATCH] i386_stab_reg_to_regnum (4 <-> 5, ebp <-> esp) References: <8011-Fri02Apr2004094123+0300-eliz@gnu.org> <2719-Fri02Apr2004213907+0300-eliz at gnu dot org> X-SW-Source: 2004-04/txt/msg00157.txt.bz2 Date: Mon, 5 Apr 2004 18:19:09 -0500 (CDT) From: Brian Ford > The big question is, "Why wasn't it noticed before?" but there's an > answer to that which seems pretty solid to me: > > - GCC's dbx_register_map and GDB's i386_stab_reg_to_regnum simply > aren't used on many modern systems. Every ELF target that I see in > GCC (except for i[34567]86-*-nto-qnx*) uses gcc/config/i386/i386.c's > svr4_dbx_register_map. That agrees with i386-tdep.c's > i386_dwarf_reg_to_regnum. [snip] > So just about every ELF target uses gdb/i386.c's > i386_dwarf_reg_to_regnum for both STABS and Dwarf 2. So they never > see the broken numbering. Agreed. I still propose we rename the _to_regnum functions, replacing stabs and dwarf with dbx and svr4 to reduce confusion. I'll be happy to make a patch :-). Please do so. Mark