From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19950 invoked by alias); 4 Apr 2004 21:12:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19936 invoked from network); 4 Apr 2004 21:12:34 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 4 Apr 2004 21:12:34 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1BAEv3-0001II-NQ; Sun, 04 Apr 2004 17:12:41 -0400 Date: Sun, 04 Apr 2004 21:12:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/testsuite] Fix expected output for "help set follow-fork-mode" Message-ID: <20040404211241.GA4932@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20040404203539.GG871@gnat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040404203539.GG871@gnat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-04/txt/msg00117.txt.bz2 On Sun, Apr 04, 2004 at 01:35:39PM -0700, Joel Brobecker wrote: > There has been a recent change to infrun (made on 2004-01-13) that > removed the choice "ask" to the possible values for "follow-fork-mode". > The help text for that variable was then modified, but the test > verifying that the help for this command exists has not been modified. > > This patch updates the expected output to match the new help text. > > 2004-04-04 Joel Brobecker > > * gdb.base/foll-fork.exp: Update the expected output for > "help set follow-fork-mode", to match a change that was made > to the help of this variable on 2004-01-13. > > Checked in as obvious. Thanks. I keep meaning to fix up this test to run, when possible, on GNU/Linux; but there's some trickiness involved and I've failed to do it adequately a few times now. > > I don't really know the purpose of this test. If, as the comment > suggests: > > # Verify that help is available for "set follow-fork-mode". > > Then I would recommend that we don't need to check for the entire > help text word for word. I would simply check for the first line, > or even maybe just check that we receive something, anything, before > we get the prompt back. I agree, personally. > (BTW, Is it really necessary to use send_gdb + gdb_expect? Could gdb_test > work just as well?) Yes, feel free. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer