From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18208 invoked by alias); 1 Apr 2004 06:18:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18197 invoked from network); 1 Apr 2004 06:18:29 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 1 Apr 2004 06:18:29 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 6578647D62; Wed, 31 Mar 2004 22:18:28 -0800 (PST) Date: Thu, 01 Apr 2004 06:18:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite/ada] Do not abort prematurely the test upon build failure Message-ID: <20040401061828.GN888@gnat.com> References: <20040401023006.GL888@gnat.com> <20040401040241.GA14882@nevyn.them.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="UExESr5xZTMxdOWv" Content-Disposition: inline In-Reply-To: <20040401040241.GA14882@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00013.txt.bz2 --UExESr5xZTMxdOWv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1337 > Unfortunately you didn't pick the best example... please do something > like issuing one UNSUPPORTED and then returning. > gdb_suppress_entire_file is evil. I knew it! :-) (there's something evil, and sure enough I pick it) UNSUPPORTED sounds better indeed. Thanks for the suggestion. I'd like to put the call to unsupported inside gdb_compile_ada in order to help having a certain consistency between all Ada testcases. So I'd like to suggest the attached patch instead. The code in null_record.exp can thus remain the same (simply abort if gdb_compile_ada returns a failure, nothing else to do since the unsupported has already been emitted). 2004-03-31 Joel Brobecker * lib/ada.exp (gdb_compile_ada): Emit UNSUPPORTED if we failed to build the application. Remove the message printed when in verbose mode, redundant with the UNSUPPORTED message above. (not sure if I used the proper terminology in the ChangeLog entry) Otherwise, the other approach would be to add the call to unsupported in null_record.exp itself. In that case, it might be nice to have the reason for the failure. For that, we would need to update the message returned by gdb_compile_ada to include that reason, and then include that reason in the UNSUPPORTED message. Would either approach be ok? -- Joel --UExESr5xZTMxdOWv Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ada.exp.diff" Content-length: 639 Index: ada.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/ada.exp,v retrieving revision 1.1 diff -u -p -r1.1 ada.exp --- ada.exp 1 Apr 2004 00:51:13 -0000 1.1 +++ ada.exp 1 Apr 2004 06:06:59 -0000 @@ -405,7 +405,7 @@ proc gdb_compile_ada {source dest type o # We therefore simply check whether the dest file has been created # or not. Unless not present, the build has succeeded. if ![file exists $dest] { - verbose "Ada compilation failed: $result" + unsupported "Ada compilation failed: $result" return "Ada compilation failed." } } --UExESr5xZTMxdOWv--