From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22825 invoked by alias); 31 Mar 2004 22:21:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22812 invoked from network); 31 Mar 2004 22:21:18 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 31 Mar 2004 22:21:18 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1B8o5I-0001tw-VL; Wed, 31 Mar 2004 17:21:20 -0500 Date: Wed, 31 Mar 2004 22:21:00 -0000 From: Daniel Jacobowitz To: Kris Warkentin Cc: "Gdb-Patches@Sources.Redhat.Com" Subject: Re: [patch] Bring QNX Neutrino support forward. Message-ID: <20040331222120.GB6811@nevyn.them.org> Mail-Followup-To: Kris Warkentin , "Gdb-Patches@Sources.Redhat.Com" References: <4060A9C0.1090906@qnx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4060A9C0.1090906@qnx.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-03/txt/msg00773.txt.bz2 Some small comments. On Tue, Mar 23, 2004 at 04:18:56PM -0500, Kris Warkentin wrote: > ChangeLog entry: > * nto-tdep.h: Include osabi.h. Prototypes for generic Neutrino Leading tabs in the ChangeLog entry, please :) Post what you would check in. > +#define nto_fetch_link_map_offsets \ > +(current_nto_target.nto_fetch_link_map_offsets) I believe this should be indented. I'm not sure how far, I usually use two spaces. > - return openp (buf, 1, solib, o_flags, 0, temp_pathname); > + /* Don't assume basename() isn't destructive. */ > + base = strrchr (solib, '/'); > + if (!base) > + base = solib; > + else > + base++; /* Skip over '/'. */ There's an lbasename in libiberty, for this reason. You should use that instead. > + ret = openp (buf, 1, base, o_flags, 0, temp_pathname); > + if (ret < 0 && base != solib) > + { > + sprintf (arch_path, "/%s", solib); > + ret = open (arch_path, o_flags, 0); Er... automatically falling back to the host library? Why? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer