From: Mark Kettenis <kettenis@chello.nl>
To: brobecker@gnat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/amd64] Pb with parameter passing in inferior function call
Date: Thu, 25 Mar 2004 11:15:00 -0000 [thread overview]
Message-ID: <200403251115.i2PBFWr7000741@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040324235125.GK5083@gnat.com> (message from Joel Brobecker on Wed, 24 Mar 2004 15:51:26 -0800)
Date: Wed, 24 Mar 2004 15:51:26 -0800
From: Joel Brobecker <brobecker@gnat.com>
The problem is that type Node_Id is a 4 bytes range type. Procedure
"Pn" expects this parameter to be passed via %rdi. But there is a
slight omission in amd64_classify that does not classifies RANGE_TYPE
entities in the INTEGER class. The attached patch fixes this.
The AMD64 ABI doesn't say anything about Ada types :-(. However I
suppose this makes sense.
2004-02-24 J. Brobecker <brobecker@gnat.com>
* amd64-tdep.c (amd64_classify): make RANGE_TYPE objects be part
of the INTEGER class.
Tested on amd64-linux. No regression.
Ok to apply?
Go ahead. This is fine for the branch too if you think it is
appropriate.
Mark
next prev parent reply other threads:[~2004-03-25 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 23:51 Joel Brobecker
2004-03-25 11:15 ` Mark Kettenis [this message]
2004-03-26 23:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403251115.i2PBFWr7000741@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox