From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23380 invoked by alias); 22 Mar 2004 17:34:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23370 invoked from network); 22 Mar 2004 17:34:32 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Mar 2004 17:34:32 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i2MHYVWA001830 for ; Mon, 22 Mar 2004 12:34:31 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i2MHYUM25443 for ; Mon, 22 Mar 2004 12:34:30 -0500 Received: from cygbert.vinschen.de (vpn50-46.rdu.redhat.com [172.16.50.46]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i2MHYSR03327 for ; Mon, 22 Mar 2004 09:34:29 -0800 Received: by cygbert.vinschen.de (Postfix, from userid 500) id B8F075853E; Mon, 22 Mar 2004 18:34:22 +0100 (CET) Date: Mon, 22 Mar 2004 17:34:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] minsyms.c: Fix switching to GNU v3 ABI Message-ID: <20040322173422.GK17229@cygbert.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20040310105709.GJ25204@cygbert.vinschen.de> <20040310150822.GA31014@nevyn.them.org> <20040310155450.GN25204@cygbert.vinschen.de> <20040310160410.GA410@nevyn.them.org> <20040310161617.GO25204@cygbert.vinschen.de> <20040310162011.GA1067@nevyn.them.org> <20040310163416.GP25204@cygbert.vinschen.de> <20040310163716.GA2114@nevyn.them.org> <20040310175446.GR25204@cygbert.vinschen.de> <20040310182259.GT25204@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040310182259.GT25204@cygbert.vinschen.de> User-Agent: Mutt/1.4.2i X-RedHat-Spam-Score: -4.9 X-SW-Source: 2004-03/txt/msg00499.txt.bz2 Hi, could any symlink maintainer have a say on this? Thanks, Corinna On Mar 10 19:22, Corinna Vinschen wrote: > On Mar 10 18:54, Corinna Vinschen wrote: > > * minsyms.c (install_minimal_symbols): Move dropping leading > > char from linkage name from here... > > (prim_record_minimal_symbol_and_info): ...to here. > > Corrected patch below. I forgot to remove the now unused leading_char > from install_minimal_symbols. > > Corinna > > > Index: minsyms.c > =================================================================== > RCS file: /cvs/src/src/gdb/minsyms.c,v > retrieving revision 1.41 > diff -u -p -r1.41 minsyms.c > --- minsyms.c 9 Feb 2004 19:13:46 -0000 1.41 > +++ minsyms.c 10 Mar 2004 18:20:36 -0000 > @@ -611,6 +611,8 @@ prim_record_minimal_symbol_and_info (con > msymbol = &msym_bunch->contents[msym_bunch_index]; > SYMBOL_INIT_LANGUAGE_SPECIFIC (msymbol, language_unknown); > SYMBOL_LANGUAGE (msymbol) = language_auto; > + if (name[0] == get_symbol_leading_char (objfile->obfd)) > + ++name; > SYMBOL_SET_NAMES (msymbol, (char *)name, strlen (name), objfile); > > SYMBOL_VALUE_ADDRESS (msymbol) = address; > @@ -831,7 +833,6 @@ install_minimal_symbols (struct objfile > struct msym_bunch *bunch; > struct minimal_symbol *msymbols; > int alloc_count; > - char leading_char; > > if (msym_count > 0) > { > @@ -859,18 +860,11 @@ install_minimal_symbols (struct objfile > each bunch is full. */ > > mcount = objfile->minimal_symbol_count; > - leading_char = get_symbol_leading_char (objfile->obfd); > > for (bunch = msym_bunch; bunch != NULL; bunch = bunch->next) > { > for (bindex = 0; bindex < msym_bunch_index; bindex++, mcount++) > - { > - msymbols[mcount] = bunch->contents[bindex]; > - if (SYMBOL_LINKAGE_NAME (&msymbols[mcount])[0] == leading_char) > - { > - SYMBOL_LINKAGE_NAME (&msymbols[mcount])++; > - } > - } > + msymbols[mcount] = bunch->contents[bindex]; > msym_bunch_index = BUNCH_SIZE; > } -- Corinna Vinschen Cygwin Developer Red Hat, Inc.