Re: [ob] user-regs.c build fix for arm-linux

Daniel Jacobowitz
2004-02-29T00:53:05Z

On Sat, Feb 28, 2004 at 01:49:48PM -0500, Andrew Cagney wrote:
> >On Sat, Feb 28, 2004 at 12:35:52PM -0500, Andrew Cagney wrote:
> >
> >>>>>+/* We call this gdb_user_regs instead of user_regs to avoid conflicts
> >>>>with
> >>>>>+ any struct user_regs in system headers (for instance, ARM
> >>>>GNU/Linux). >*/
> >>
> >>>
> >>>Please be more explicit.
> >
> >
> >What else would you like to know? What header it comes from?
>
> Er, yes? The comment should describe the exact cause of the problem.
> Otherwize there is no way to audit this stuff later.
>
> BTW, wouldn't this stuff, and not ICU have been a better thing to do
> last weekend?

Andrew, please do not attempt to dictate to me the use of my time as a
volunteer. I have already explained to you that ICU is important to me
and to the distributions I contribute to, and I resent your continual
objections. I'm perfectly willing for my submitted patches to sit and
wait until after the branch.

The next important thing on my list after that was merging our internal
tree to the GDB HEAD for testing purposes, and that's what I'm doing
now. I'll do MIPS next week. Normally I wouldn't do any of this until
after the branch was cut anyway.